Skip to content

Update gdb_expansion.ts #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaoyun94 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update gdb_expansion.ts #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/backend/gdb_expansion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export function expandValue(variableCreate: (arg: VariableObject | string, optio
ref = variableCreate(val);
val = "Object";
} else if (typeof val === "string" && val.startsWith("*0x")) {
if (extra && MINode.valueOf(extra, "arg") == "1") {
if (extra && MINode.valueOf(extra, "type") == "char **") {
ref = variableCreate(getNamespace("*(" + name), { arg: true });
Comment on lines +232 to 233

@GitMensch GitMensch Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous version checked if it is an arg - and showed it that way + got the content, now that is always done if the type is a char **...

Do we need to split that (haven't checked what arg:true does)?

Also: is it possible to add a testcase for that to ensure a follow-up commit does not break it?

val = "<args>";
} else {
Expand Down
Loading