Skip to content

Drop the redundant public from the fixtures' set-only properties #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahegyes merged 1 commit into from
Oct 29, 2026
Merged

Drop the redundant public from the fixtures' set-only properties #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/Fixtures/consumer-a/src/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ final class Plugin {
*
* @var MigrationRunner|null
*/
public protected(set) ?MigrationRunner $migrations = null;
protected(set) ?MigrationRunner $migrations = null;

/**
* The kernel, once the composition built it, which tells which components loaded and which were gated off.
Expand All @@ -99,7 +99,7 @@ final class Plugin {
*
* @var PluginKernel|null
*/
public protected(set) ?PluginKernel $kernel = null;
protected(set) ?PluginKernel $kernel = null;

/**
* The logger every part of the plugin writes to.
Expand Down
2 changes: 1 addition & 1 deletion tests/Fixtures/consumer-b/src/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ final class Plugin {
*
* @var PluginKernel|null
*/
public protected(set) ?PluginKernel $kernel = null;
protected(set) ?PluginKernel $kernel = null;

/**
* The logger every part of the plugin writes to.
Expand Down
2 changes: 1 addition & 1 deletion tests/Fixtures/personas/core/src/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ final class Plugin {
*
* @var PluginKernel|null
*/
public protected(set) ?PluginKernel $kernel = null;
protected(set) ?PluginKernel $kernel = null;

/**
* The logger every part of the plugin writes to.
Expand Down
Loading