Repository navigation
Drop the redundant public from the fixtures' set-only properties - #64
Merged
Merged
Conversation
consumer-a, consumer-b and the core persona declared their kernel and migration runner as public protected(set), while a set-only visibility already reads as public. The packages write protected(set) alone, and the style guide's rule covers plugin code, so the fixtures that model a plugin's anatomy follow it as well. Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary. consumer-a, consumer-b and the core persona declare their kernel and migration runner as
public protected(set), while a set-only visibility already reads as public. The packages writeprotected(set)alone, and the style rule covers plugin code too, so the fixtures that model a plugin's anatomy follow it. ahegyes/wordpress-plugin-template#19 makes the same change in the template.$migrationsand$kernel, consumer-b's$kerneland the core persona's$kerneldrop thepublic; no behavior change.Fixtures +4 −4 (3 files).
Testing.
composer quality-checkpasses: validate, changelog validation, PHPCS on both profiles, the PHPStan profiles and every fixture's, Unit 189 and Integration 1333.composer test:integration:multisitepasses (40, consumer-b's rows among them), andcomposer test:integration:php74passes (2).