Repository navigation
Drop the redundant public from the plugin's set-only properties - #19
Merged
Merged
Conversation
Plugin declared $migrations and $kernel as public protected(set), while a set-only visibility already reads as public. The framework packages write protected(set) alone, and the style guide's rule covers plugin code too, so the template now matches what every plugin copies from it. Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugindeclares$migrationsand$kernelaspublic protected(set), while a set-only visibility already reads as public. The framework packages writeprotected(set)alone, and the style rule covers plugin code too, so the template matches what every plugin copies from it. ahegyes/wordpress-framework#64 makes the same change in the framework's fixtures.src/Plugin.php's$migrationsand$kerneldrop thepublic; no behavior change.Code +2 −2.
Type of change
Checklist
composer changelog:add): none; the v2 rebuild ships as "Initial release."composer quality-checkpasses locallyTesting.
composer quality-checkpasses: validate, changelog validation, PHPCS on both profiles, PHPStan level 10, Unit 6 and Integration 70.npm run test:e2epasses (3 of 3);lint:scripts,lint:stylesandlint:typesare clean.