Repository navigation
feat(cloud): link direct-access guidance to the dedicated enable-direct-access route - #1364
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1791848973-direct-access-enable-route' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1791848973-direct-access-enable-route'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
There was a problem hiding this comment.
🔵 Needs a closer look
Deployment must be coordinated with the external Cloud webapp route dependency.
0 open findings
What changed in this PR
Updates disabled-direct-access guidance to open the dedicated Cloud enablement page with consent explicitly required.
Changes:
- Targets
/enable-direct-access?skip-consent-screen=false. - Updates cached-name and fallback-label test expectations.
| File | Description |
|---|---|
airbyte/cloud/connectors.py |
Builds the dedicated enablement URL. |
tests/unit_tests/test_cloud_direct_execute.py |
Verifies updated guidance links. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Code Coverage OverviewLanguages: Python Python / code-coverage/pytest-no-credsThe overall line coverage in commit 0c123e6 in the Show a line coverage summary of the most impacted files.
Python / code-coverage/pytestThe overall line coverage in commit 0c123e6 in the Show a line coverage summary of the most impacted files.
Python / code-coverage/pytest-unitThe overall line coverage in commit 0c123e6 in the Show a line coverage summary of the most covered files.
Updated |
a144379 to
da1486d
Compare
885aa0e to
0d79393
Compare
0d79393 to
e463282
Compare
…ct-access route Co-Authored-By: AJ Steers <aj@airbyte.io>
e463282 to
0c123e6
Compare
|
Devin, lmk in slack when the cloud-side endpoints are live. |
3cab732
into
release-candidate/v1
Overview
👉 TL;DR: The "Direct access is currently disabled" link now opens the new Cloud page that enables direct access for the connector. It used to open the connector's settings page.
CloudConnector._direct_access_enablement_urlnow returns{connector_url}/enable-direct-access?skip-consent-screen=false.Stacked on #1363. Depends on the Cloud route from airbyte-platform-internal#19884; don't merge this until that route is deployed. Part of AGENTIC-2340.
Changes
skip-consent-screen=falseexplicitly, so users always see the consent screen. This can be flipped later once one-click enable is considered safe.Risks
errors), not in error text, so the query string reaches the agent intact.Link to Devin session: https://app.devin.ai/sessions/bb884d35f6d24ad993d7f494e660acbc
Open in Devin Desktop: https://app.devin.ai/desktop/session/bb884d35f6d24ad993d7f494e660acbc?variant=devin
Requested by: Aaron ("AJ") Steers (@aaronsteers)