Skip to content

feat(cloud): link direct-access guidance to the dedicated enable-direct-access route - #1364

Merged
Aaron ("AJ") Steers (aaronsteers) merged 1 commit into
release-candidate/v1from
devin/1791848973-direct-access-enable-route
Oct 16, 2026
Merged

Aaron ("AJ") Steers (aaronsteers) merged 1 commit into
release-candidate/v1from
devin/1791848973-direct-access-enable-route

Conversation

@aaronsteers

@aaronsteers Aaron ("AJ") Steers (aaronsteers) commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Overview

👉 TL;DR: The "Direct access is currently disabled" link now opens the new Cloud page that enables direct access for the connector. It used to open the connector's settings page.

CloudConnector._direct_access_enablement_url now returns {connector_url}/enable-direct-access?skip-consent-screen=false.

Stacked on #1363. Depends on the Cloud route from airbyte-platform-internal#19884; don't merge this until that route is deployed. Part of AGENTIC-2340.

Changes

  • Overrides one property. The message text is unchanged.
  • Passes skip-consent-screen=false explicitly, so users always see the consent screen. This can be flipped later once one-click enable is considered safe.
  • Tests: updated the expected URLs.

Risks

  • If this merges before the Cloud route ships, the link points to a route that doesn't exist yet.
  • The link is returned in the tool result (errors), not in error text, so the query string reaches the agent intact.

Link to Devin session: https://app.devin.ai/sessions/bb884d35f6d24ad993d7f494e660acbc
Open in Devin Desktop: https://app.devin.ai/desktop/session/bb884d35f6d24ad993d7f494e660acbc?variant=devin
Requested by: Aaron ("AJ") Steers (@aaronsteers)

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@linear-code

linear-code Bot commented Oct 12, 2026

Copy link
Copy Markdown

AGENTIC-2340

@github-actions

Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This PyAirbyte Version

You can test this version of PyAirbyte using the following:

# Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1791848973-direct-access-enable-route' pyairbyte --help

# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1791848973-direct-access-enable-route'

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /fix-pr - Fixes most formatting and linting issues
  • /uv-lock - Updates uv.lock file
  • /test-pr - Runs tests with the updated PyAirbyte
  • /prerelease - Builds and publishes a prerelease version to PyPI
📚 Show Repo Guidance

Helpful Resources

Community Support

Questions? Join the #pyairbyte channel in our Slack workspace.

📝 Edit this welcome message.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Deployment must be coordinated with the external Cloud webapp route dependency.

0 open findings

What changed in this PR

Updates disabled-direct-access guidance to open the dedicated Cloud enablement page with consent explicitly required.

Changes:

  • Targets /enable-direct-access?skip-consent-screen=false.
  • Updates cached-name and fallback-label test expectations.
File Description
airbyte/​cloud/​connectors.py Builds the dedicated enablement URL.
tests/​unit_tests/​test_cloud_direct_execute.py Verifies updated guidance links.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-code-quality

github-code-quality Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest-no-creds

The overall line coverage in commit 0c123e6 in the devin/1791848973-dir... branch is 79%. The line coverage in commit d9f652f in the release-candidate/v1 branch is 65%.

Show a line coverage summary of the most impacted files.
File release-candidate/v1 d9f652f devin/1791848973-dir... 0c123e6 +/-
airbyte/mcp/cloud.py 52% 83% +31%
airbyte/_util/api_util.py 36% 68% +32%
airbyte/cloud/connectors.py 34% 75% +41%
airbyte/mcp/_datadog.py 0% 50% +50%
airbyte/mcp/_user_identity.py 0% 93% +93%
airbyte/_direct...ctors/models.py 0% 94% +94%
airbyte/mcp/_telemetry.py 0% 94% +94%
airbyte/mcp/_sso_auth.py 0% 96% +96%
airbyte/cloud/models.py 0% 97% +97%
airbyte/mcp/int...nc_status_ui.py 0% 97% +97%

Python / code-coverage/pytest

The overall line coverage in commit 0c123e6 in the devin/1791848973-dir... branch is 81%. The line coverage in commit d9f652f in the release-candidate/v1 branch is 71%.

Show a line coverage summary of the most impacted files.
File release-candidate/v1 d9f652f devin/1791848973-dir... 0c123e6 +/-
airbyte/cloud/connectors.py 51% 80% +29%
airbyte/mcp/cloud.py 52% 83% +31%
airbyte/mcp/_datadog.py 0% 50% +50%
airbyte/mcp/int..._registry_ui.py 0% 92% +92%
airbyte/mcp/_user_identity.py 0% 93% +93%
airbyte/_direct...ctors/models.py 0% 94% +94%
airbyte/mcp/_telemetry.py 0% 94% +94%
airbyte/mcp/_sso_auth.py 0% 96% +96%
airbyte/cloud/models.py 0% 97% +97%
airbyte/mcp/int...nc_status_ui.py 0% 97% +97%

Python / code-coverage/pytest-unit

The overall line coverage in commit 0c123e6 in the devin/1791848973-dir... branch is 76%. Line coverage data for the release-candidate/v1 branch is not yet available.

Show a line coverage summary of the most covered files.
File release-candidate/v1 devin/1791848973-dir... 0c123e6 +/-
airbyte/cloud/models.py — 97% —
airbyte/mcp/_sso_auth.py — 96% —
airbyte/_direct...ctors/models.py — 94% —
airbyte/cloud/client.py — 90% —
airbyte/exceptions.py — 89% —
airbyte/mcp/cloud.py — 83% —
airbyte/progress.py — 80% —
airbyte/cloud/connectors.py — 75% —
airbyte/_util/api_util.py — 68% —
airbyte/shared/...ql_processor.py — 68% —

Updated October 13, 2026 01:34 UTC

@aaronsteers
Aaron ("AJ") Steers (aaronsteers) added this pull request to stack #1365 October 12, 2026 23:57
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/1791848973-direct-access-enable-route branch from a144379 to da1486d Compare October 12, 2026 23:58
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/1791848973-direct-access-enable-route branch 2 times, most recently from 885aa0e to 0d79393 Compare October 13, 2026 00:20
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/1791848973-direct-access-enable-route branch from 0d79393 to e463282 Compare October 13, 2026 00:59
Base automatically changed from devin/1791846541-direct-access-enable-link to release-candidate/v1 October 13, 2026 01:22
…ct-access route

Co-Authored-By: AJ Steers <aj@airbyte.io>
@aaronsteers
Aaron ("AJ") Steers (aaronsteers) force-pushed the devin/1791848973-direct-access-enable-route branch from e463282 to 0c123e6 Compare October 13, 2026 01:22
Comment thread tests/unit_tests/test_cloud_direct_execute.py
Comment thread tests/unit_tests/test_cloud_direct_execute.py
@aaronsteers

Copy link
Copy Markdown
Member Author

Devin, lmk in slack when the cloud-side endpoints are live.

@aaronsteers
Aaron ("AJ") Steers (aaronsteers) marked this pull request as ready for review October 16, 2026 02:23
@aaronsteers
Aaron ("AJ") Steers (aaronsteers) merged commit 3cab732 into release-candidate/v1 Oct 16, 2026
30 of 31 checks passed
@aaronsteers
Aaron ("AJ") Steers (aaronsteers) deleted the devin/1791848973-direct-access-enable-route branch October 16, 2026 02:24

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Deployment of the required Cloud route remains unverified and needs confirmation before merging.

0 open findings

🧠 Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants