Skip to content

feat(cloud): link direct-access guidance to the dedicated enable-direct-access route #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaron ("AJ") Steers (aaronsteers) merged 1 commit into from
Oct 16, 2026
Merged

feat(cloud): link direct-access guidance to the dedicated enable-direct-access route #1364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte/cloud/connectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ def _raise_if_feature_not_enabled(
@property
def _direct_access_enablement_url(self) -> str:
"""Get the web URL where the user can enable direct access for this connector."""
return self.connector_url
return f"{self.connector_url}/enable-direct-access?skip-consent-screen=false"

def _execute_direct_action( # noqa: PLR0913 # Explicit args mirror the public methods.
self,
Expand Down
10 changes: 8 additions & 2 deletions tests/unit_tests/test_cloud_direct_execute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,10 @@ def test_execute_error_handling(
assert isinstance(exc_info.value, AirbyteExternalAccessNotEnabledError)
assert exc_info.value.connector_id == "source-1"
assert exc_info.value.connector_name == "GitHub Issues"
assert exc_info.value.enablement_url == source.connector_url
assert (
exc_info.value.enablement_url
== f"{source.connector_url}/enable-direct-access?skip-consent-screen=false"
)
Comment thread
aaronsteers marked this conversation as resolved.
assert exc_info.value.guidance == AirbyteExternalAccessNotEnabledError.guidance
else:
assert isinstance(exc_info.value, AirbyteCloudError)
Expand Down Expand Up @@ -372,7 +375,10 @@ def test_execute_error_sets_enablement_url_without_connector_info(
):
source.execute_api_query("issues")

assert exc_info.value.enablement_url == source.connector_url
assert (
exc_info.value.enablement_url
== f"{source.connector_url}/enable-direct-access?skip-consent-screen=false"
)
Comment thread
aaronsteers marked this conversation as resolved.
assert exc_info.value.guidance == AirbyteExternalAccessNotEnabledError.guidance


Expand Down
Loading