Repository navigation
nvidia-alchemi: fix dependency advisories and release smoke import path - #2
Merged
anogassis merged 3 commits intoOct 28, 2026
Conversation
- Bump certifi to 2026.10.19 (GHSA-6q48-6c7w-9gw2, critical), which dependency review flagged after the previous fixes merged. - Let the checkpoint downloader tests locate /app/build themselves, so `python /app/release_smoke.py` runs unchanged in the deployed image. Image-build tests now run with the runtime PYTHONPATH to catch this. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependency Review fails on high or critical advisories. These were reviewed after the previous update and affect the pinned versions: - Pillow 12.3.0 -> 13.0.0 (28 high/critical, including 5 critical) - GitPython 3.1.62 -> 3.2.1 (5 high) - aiohttp 3.14.3 -> 3.14.4 (3 high) - filelock 3.32.3 -> 4.2.1 (1 high) - hydra-core 1.3.7 -> 1.3.8 (1 high) - setuptools 84.0.0 -> 84.1.0 (1 low) No pinned package declares a conflict with these versions, and none of them has a known advisory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aiohttp 3.14.4 requires yarl>=1.25.1; the image build's pip check rejected yarl 1.24.5. An offline pip-check of all 198 pins finds no other violations, and yarl 1.25.1 has no known advisories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8 of 17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes for microsoft#212 after #1 merged: update dependencies with high or critical advisories reviewed after the previous update (
certifi,pillow,GitPython,aiohttp,filelock,hydra-core), and makepython /app/release_smoke.pyrun unchanged in the deployed image.Type of change
agents/<name>/)starter-kits/<name>/)docs/schemas/**).github/**)Related issue / tracking
refs microsoft#212; follows #1.
Schema impact
breaking-changelabel and link the rollout plan belowValidation checklist
README.md, schemas) is updated to match the change..auto-registry/**(it is generated post-merge)..DS_Store,.env,*.swp,.idea/,.vs/, etc.).Reviewer notes (optional)
1. certifi (Dependency Review failure). After #1 merged, Dependency Review still failed on one package:
certifi==2026.7.22is affected by GHSA-6q48-6c7w-9gw2 (critical; compromised emSign intermediate CA keys), published 2026-10-20. Bumped to the first patched release,2026.10.19. The four packages updated in #1 no longer appear.2. Release smoke import path (bug introduced in #1).
test_download_checkpoints.pyimported the downloader from/app/build, which is intentionally not on the runtimePYTHONPATH. The image-build test step added it explicitly, so the build passed, butpython /app/release_smoke.pyin the deployed image would report one import error and fail the regression gate. The test now locates the downloader itself (repository or/app/buildlayout), and the image-build step runs with the runtimePYTHONPATHso this cannot regress silently.Validation on this exact commit:
PYTHONPATHonly; the fixed test passes there and in the repository layout.PYTHONPATH;pip checkpassed;certifi-2026.10.19installed.agent.yaml,tool.yamland all runtime Python modules are unchanged from nvidia-alchemi: hardening fixes and H100 revalidation for #212 #1, so the H100 model and dynamics results from nvidia-alchemi: hardening fixes and H100 revalidation for #212 #1 still apply. A GPU rerun of the release validation on this image is planned.3. Dependency advisories reviewed after the previous update. A check of all 198 pins against GitHub-reviewed advisories found high or critical advisories affecting these pinned versions. Dependency Review fails at high severity, so these would block microsoft#212 once its advisory data catches up:
Validation on commit
cee6af3: an offlinepip checkof every pin's declared requirements finds no conflicts; a clean image build installs all versions above,pip checkpasses, and all 43 tests pass with no skips; no pinned package has a known advisory. A GPU rerun of the release validation on this image is planned becausepillowandfilelockchange major versions.New advisories are being published against these packages daily; enabling Dependabot for
requirements-build.txtwould keep the pins current.