Skip to content

nvidia-alchemi: fix dependency advisories and release smoke import path - #2

Merged
anogassis merged 3 commits into
anogassis:add-nvidia-alchemi-agentfrom
faranm-stack:pr212-hardening-2
Oct 28, 2026
Merged

anogassis merged 3 commits into
anogassis:add-nvidia-alchemi-agentfrom
faranm-stack:pr212-hardening-2

Conversation

@faranm-stack

@faranm-stack faranm-stack commented Oct 23, 2026 •

Copy link
Copy Markdown

Summary

Follow-up fixes for microsoft#212 after #1 merged: update dependencies with high or critical advisories reviewed after the previous update (certifi, pillow, GitPython, aiohttp, filelock, hydra-core), and make python /app/release_smoke.py run unchanged in the deployed image.

Type of change

  • New agent (under agents/<name>/)
  • Update to an existing agent
  • New starter kit (under starter-kits/<name>/)
  • Update to an existing starter kit
  • Schema change (docs/schemas/**)
  • Workflow / script change (.github/**)
  • Documentation only
  • Other (describe below)

Related issue / tracking

refs microsoft#212; follows #1.

Schema impact

  • No schema changes
  • Schema changes are backward compatible
  • Schema changes are breaking — add the breaking-change label and link the rollout plan below

Validation checklist

  • Documentation (README.md, schemas) is updated to match the change.
  • No hand-edits to .auto-registry/** (it is generated post-merge).
  • No OS / editor artefacts committed (.DS_Store, .env, *.swp, .idea/, .vs/, etc.).
  • If model-weight files are added, they are Git-LFS tracked, ≤5 GB each, and in an allowed format. (No model-weight files added.)
  • No secrets, customer data, or internal-only URLs are committed.
  • All Markdown links resolve.

Reviewer notes (optional)

1. certifi (Dependency Review failure). After #1 merged, Dependency Review still failed on one package: certifi==2026.7.22 is affected by GHSA-6q48-6c7w-9gw2 (critical; compromised emSign intermediate CA keys), published 2026-10-20. Bumped to the first patched release, 2026.10.19. The four packages updated in #1 no longer appear.

2. Release smoke import path (bug introduced in #1). test_download_checkpoints.py imported the downloader from /app/build, which is intentionally not on the runtime PYTHONPATH. The image-build test step added it explicitly, so the build passed, but python /app/release_smoke.py in the deployed image would report one import error and fail the regression gate. The test now locates the downloader itself (repository or /app/build layout), and the image-build step runs with the runtime PYTHONPATH so this cannot regress silently.

Validation on this exact commit:

3. Dependency advisories reviewed after the previous update. A check of all 198 pins against GitHub-reviewed advisories found high or critical advisories affecting these pinned versions. Dependency Review fails at high severity, so these would block microsoft#212 once its advisory data catches up:

Package Was Now Reviewed advisories
pillow 12.3.0 13.0.0 28 high/critical (5 critical)
GitPython 3.1.62 3.2.1 5 high
aiohttp 3.14.3 3.14.4 3 high
filelock 3.32.3 4.2.1 1 high
hydra-core 1.3.7 1.3.8 1 high
setuptools 84.0.0 84.1.0 1 low
yarl 1.24.5 1.25.1 none; required by aiohttp 3.14.4

Validation on commit cee6af3: an offline pip check of every pin's declared requirements finds no conflicts; a clean image build installs all versions above, pip check passes, and all 43 tests pass with no skips; no pinned package has a known advisory. A GPU rerun of the release validation on this image is planned because pillow and filelock change major versions.

New advisories are being published against these packages daily; enabling Dependabot for requirements-build.txt would keep the pins current.

faranm-stack and others added 3 commits October 23, 2026 15:57
- Bump certifi to 2026.10.19 (GHSA-6q48-6c7w-9gw2, critical), which
  dependency review flagged after the previous fixes merged.
- Let the checkpoint downloader tests locate /app/build themselves, so
  `python /app/release_smoke.py` runs unchanged in the deployed image.
  Image-build tests now run with the runtime PYTHONPATH to catch this.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependency Review fails on high or critical advisories. These were reviewed
after the previous update and affect the pinned versions:

- Pillow 12.3.0 -> 13.0.0 (28 high/critical, including 5 critical)
- GitPython 3.1.62 -> 3.2.1 (5 high)
- aiohttp 3.14.3 -> 3.14.4 (3 high)
- filelock 3.32.3 -> 4.2.1 (1 high)
- hydra-core 1.3.7 -> 1.3.8 (1 high)
- setuptools 84.0.0 -> 84.1.0 (1 low)

No pinned package declares a conflict with these versions, and none of them
has a known advisory.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aiohttp 3.14.4 requires yarl>=1.25.1; the image build's pip check rejected
yarl 1.24.5. An offline pip-check of all 198 pins finds no other violations,
and yarl 1.25.1 has no known advisories.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@faranm-stack faranm-stack changed the title nvidia-alchemi: fix certifi advisory and release smoke import path nvidia-alchemi: fix dependency advisories and release smoke import path Oct 27, 2026
@anogassis
anogassis merged commit 4060f26 into anogassis:add-nvidia-alchemi-agent Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants