[GH-3357] Move shared GeoPackage reader into Spark common - #3361
Merged
Conversation
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Yes, I have read the Contributor Rules and Contributor Development Guide.
Is this PR related to a ticket?
Related to #3357. This is a prerequisite cleanup for #3358; it does not implement
list_layersor close the issue.What changes were proposed in this PR?
Move the six identical GeoPackage reader classes from the Spark 3.5, 4.0, and 4.1 modules into
spark/common, keeping their packages and implementations unchanged.GeoPackageReaderTestsuite into common and remove the version-specific copies.The common module is already built separately for each Spark/Scala version. Existing shared data sources use the same layout. #3358 can be rebased onto the shared implementation after this lands.
How was this patch tested?
mvn clean package -pl spark-shaded -am -DskipTests -Dmaven.javadoc.skip=truewith the corresponding Spark and Scala profiles._metadatacolumn.git diff --checkpassed.Did this PR include necessary documentation updates?
No, this PR does not affect any public API so no need to change the documentation.