fix(jwk): handle KeySet equality with unrelated types - #106
Merged
Conversation
lepture
reviewed
Sep 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 47 47
Lines 2955 2956 +1
Branches 352 353 +1
=======================================
+ Hits 2951 2952 +1
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
janmrow
force-pushed
the
fix/keyset-equality
branch
from
September 12, 2026 21:01
0751c48 to
8cf48fd
Compare
lepture
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeySet.__eq__currently raises an exception when aKeySetis compared with an unrelated type.This PR returns
NotImplementedfor unsupported types. This lets Python handle the comparison, while keeping existingKeySet-to-KeySetcomparisons unchanged.Regression tests cover comparisons with unrelated types, also including reflected equality.
Tests on local:
pytest tests/ -qmypy src/joserfc/_keys.py