Skip to content

fix(jwk): handle KeySet equality with unrelated types #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lepture merged 2 commits into from
Sep 13, 2026
+7 −1
Merged

fix(jwk): handle KeySet equality with unrelated types #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c60e138
fix(jwk): handle KeySet equality with unrelated types
janmrow Sep 7, 2026
8cf48fd
fix(jwk): return false for unrelated KeySet comparisons
janmrow Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/joserfc/_keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ def __bool__(self) -> bool:
return bool(self.keys)

def __eq__(self, other: t.Any) -> bool:
assert isinstance(other, KeySet)
if not isinstance(other, KeySet):
return False
return self.keys == other.keys

def as_dict(self, private: bool = False, **params: t.Any) -> KeySetSerialization:
Expand Down
5 changes: 5 additions & 0 deletions tests/jwk/test_jwk_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,3 +103,8 @@ def test_key_eq_with_new_keys(self):
key_set2 = KeySet([RSAKey.import_key(k.as_dict(private=True)) for k in key_set1])
self.assertIsNot(key_set1, key_set2)
self.assertEqual(key_set1, key_set2)

def test_key_set_eq_with_unrelated_type(self):
key_set = KeySet.generate_key_set("oct", 8, count=1)
self.assertFalse(key_set == "foo")
self.assertNotEqual(key_set, "foo")
Loading