You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AgentCoreRuntimeClient accepts wait_config but users cannot import WaitConfig from its public package, and passing the region_name keyword used by other SDK clients raises TypeError.
Export WaitConfig from runtime, evaluation, gateway, knowledge_base, and policy, so callers can import it alongside the clients that accept it. Add region_name aliases to AgentCoreRuntimeClient and BatchEvaluationRunner, preserving all existing positional arguments and region selection: explicit region, then region_name, then the existing session/default fallback. Includes batch-runner precedence/compatibility tests and usage documentation.
Related to #663 (WaitConfig imports and region naming). Batch insights remain a separate discussion.
Validation:
Remaining runtime and batch-runner tests: 85 passed.
All pre-commit checks and the Bandit security scan passed.
Built wheel checked in a clean Python 3.12 environment with base dependencies only; all five public imports and real boto3 client region selection passed without service calls.
The initial full run hit an intermittent failure in the unchanged payment retry test's global time.sleep mock. All seven payment retry tests passed in isolation, and the full rerun passed. An unchanged-main comparison separately hit a memory timeout test's global time.time mock exhaustion; these unrelated tests were not changed here.
�[1msrc/bedrock_agentcore/runtime/agent_core_runtime_client.py�[0m:90: AgentCoreRuntimeClient.region: �[33mAttribute value was changed�[39m: validate_region(region or session.region_name if session else None or 'us-west-2') -> validate_region(region or region_name or session.region_name if session else None or 'us-west-2')
Note: This is an automated static analysis check. Some flagged changes may be intentional.
Please confirm each item is expected and, if so, add a migration note to CHANGELOG.md.
CI note: the red Compat (evaluation) check is pre-existing and unrelated to this change. I'll address it in a follow-up PR.
The compat job installs pytest plugins only, so v1.23.1's tests_integ/evaluation/test_third_party_adapters.py errors at setup with ModuleNotFoundError: No module named 'ragas' / 'deepeval' (16 collection errors). The same failure occurs on unrelated branches, and the job is continue-on-error: true, so the workflow run itself reports success.
Same follow-up will cover the intermittent test_zero_delay_skips_sleep failure seen on this branch's first run: ragas starts a daemon thread at import time that loops on time.sleep(1), and our tests patch sleep through a module's own time reference — which is the shared stdlib module — so that thread's wake-ups land on the mock and inflate its call count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentCoreRuntimeClientacceptswait_configbut users cannot importWaitConfigfrom its public package, and passing theregion_namekeyword used by other SDK clients raisesTypeError.Export
WaitConfigfrom runtime, evaluation, gateway, knowledge_base, and policy, so callers can import it alongside the clients that accept it. Addregion_namealiases toAgentCoreRuntimeClientandBatchEvaluationRunner, preserving all existing positional arguments and region selection: explicitregion, thenregion_name, then the existing session/default fallback. Includes batch-runner precedence/compatibility tests and usage documentation.Related to #663 (WaitConfig imports and region naming). Batch insights remain a separate discussion.
Validation:
The initial full run hit an intermittent failure in the unchanged payment retry test's global
time.sleepmock. All seven payment retry tests passed in isolation, and the full rerun passed. An unchanged-main comparison separately hit a memory timeout test's globaltime.timemock exhaustion; these unrelated tests were not changed here.