Skip to content

ci: run demo tests on minimum supported Flutter - #147

Open
reez wants to merge 1 commit into
bitcoindevkit:mainfrom
reez:version-floor
Open

reez wants to merge 1 commit into
bitcoindevkit:mainfrom
reez:version-floor

Conversation

@reez

@reez reez commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

#145 fixed a test that fails on the minimum supported Flutter.. CI didn't catch it because it only tests the latest Flutter, which resolves newer dependencies. This adds a job that runs bdk_demo tests on Flutter 3.38.3, the minimum the demo supports, so that kind of failure shows up in CI.

@reez

reez commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

@MusabYK wondering if you can review, and if this makes sense

@MusabYK

MusabYK commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@MusabYK wondering if you can review, and if this makes sense

Testing against the minimum supported Flutter version 3.38.3 is a great idea to prevent dependency and SDK regressions.

Just a quick clarification regarding the context behind #145:
The receive_page_test failure actually occurred on Flutter 3.47.4 (Dart 3.13.3) on Windows. I don't think it was caused by an older Flutter version or dependency resolution issues, but an OS-specific event loop timing difference unique to Windows runners.

Because of this, should we also consider adding flutter test for bdk_demo to the windows-smoke job in ci? This would ensure that Windows-specific test failures like this are automatically caught in CI going forward.

@reez

reez commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

@MusabYK wondering if you can review, and if this makes sense

Testing against the minimum supported Flutter version 3.38.3 is a great idea to prevent dependency and SDK regressions.

Just a quick clarification regarding the context behind #145: The receive_page_test failure actually occurred on Flutter 3.47.4 (Dart 3.13.3) on Windows. I don't think it was caused by an older Flutter version or dependency resolution issues, but an OS-specific event loop timing difference unique to Windows runners.

Because of this, should we also consider adding flutter test for bdk_demo to the windows-smoke job in ci? This would ensure that Windows-specific test failures like this are automatically caught in CI going forward.

Good catch. I reproduced the same failure on macOS with riverpod 3.3.2, so I think the cause is the pending riverpod timer rather than Windows timing. Could you check which riverpod version is in your bdk_demo/pubspec.lock? Either way, agreed on adding flutter test to windows-smoke in a followup PR.

@MusabYK

MusabYK commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Good catch. I reproduced the same failure on macOS with riverpod 3.3.2, so I think the cause is the pending riverpod timer rather than Windows timing. Could you check which riverpod version is in your bdk_demo/pubspec.lock? Either way, agreed on adding flutter test to windows-smoke in a followup PR.

That makes sense. I just checked bdk_demo/pubspec.lock , and i'm on riverpod 3.3.2 as well.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants