You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: run demo tests on minimum supported Flutter - #147
#145 fixed a test that fails on the minimum supported Flutter.. CI didn't catch it because it only tests the latest Flutter, which resolves newer dependencies. This adds a job that runs bdk_demo tests on Flutter 3.38.3, the minimum the demo supports, so that kind of failure shows up in CI.
@MusabYK wondering if you can review, and if this makes sense
Testing against the minimum supported Flutter version 3.38.3 is a great idea to prevent dependency and SDK regressions.
Just a quick clarification regarding the context behind #145:
The receive_page_test failure actually occurred on Flutter 3.47.4 (Dart 3.13.3) on Windows. I don't think it was caused by an older Flutter version or dependency resolution issues, but an OS-specific event loop timing difference unique to Windows runners.
Because of this, should we also consider adding flutter test for bdk_demo to the windows-smoke job in ci? This would ensure that Windows-specific test failures like this are automatically caught in CI going forward.
@MusabYK wondering if you can review, and if this makes sense
Testing against the minimum supported Flutter version 3.38.3 is a great idea to prevent dependency and SDK regressions.
Just a quick clarification regarding the context behind #145: The receive_page_test failure actually occurred on Flutter 3.47.4 (Dart 3.13.3) on Windows. I don't think it was caused by an older Flutter version or dependency resolution issues, but an OS-specific event loop timing difference unique to Windows runners.
Because of this, should we also consider adding flutter test for bdk_demo to the windows-smoke job in ci? This would ensure that Windows-specific test failures like this are automatically caught in CI going forward.
Good catch. I reproduced the same failure on macOS with riverpod 3.3.2, so I think the cause is the pending riverpod timer rather than Windows timing. Could you check which riverpod version is in your bdk_demo/pubspec.lock? Either way, agreed on adding flutter test to windows-smoke in a followup PR.
Good catch. I reproduced the same failure on macOS with riverpod 3.3.2, so I think the cause is the pending riverpod timer rather than Windows timing. Could you check which riverpod version is in your bdk_demo/pubspec.lock? Either way, agreed on adding flutter test to windows-smoke in a followup PR.
That makes sense. I just checked bdk_demo/pubspec.lock , and i'm on riverpod 3.3.2 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#145 fixed a test that fails on the minimum supported Flutter.. CI didn't catch it because it only tests the latest Flutter, which resolves newer dependencies. This adds a job that runs
bdk_demotests on Flutter 3.38.3, the minimum the demo supports, so that kind of failure shows up in CI.