Repository navigation
Swarm names: leave the organization out, and add swarm config name - #40
Merged
Merged
Conversation
swarm config create named a swarm after its whole ID when --name wasn't given, so a shared swarm got "<org>/<swarm>" as its name. The organization only says where the swarm is kept, so leave it out.
The name a swarm is shown with could only be set when creating it. The new command shows it, or sets it for the selected swarm (or --swarm), local or shared; the ID stays the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #35.
Default name of a shared swarm
swarm config create <org>/<swarm>without--namenamed the swarm after its whole ID, so it was shown as<org>/<swarm>everywhere. The organization only says where the swarm is kept, so the default is now the ID without it:swarm config create bitcraze-lab/demogives the namedemo. Local swarms are still named after their ID.swarm config nameThe name could only be set when creating a swarm. The new command shows it, or sets it, for the selected swarm or the one given with
--swarm, local or shared. The ID stays the same.cfcli swarm config name cfcli swarm config name "Lab bench" --swarm bitcraze-lab/demoAn empty name is refused (exit 30, invalid value). For a shared swarm the change is uploaded like any other, so it is a new revision and a colleague's change in between is kept.
Testing
create bitcraze/name-testnamed itname-test;create bitcraze/name-test-2 --name "Soft name"kept the given name;create local-name-testnamed itlocal-name-testswarm config nameshowed and changed the name of a shared swarm (new revision on the server) and of a local one (file updated); a swarm created with the old<org>/<swarm>name could be renamedswarm config name " "was refused with exit 30