Repository navigation
Conversation
defaults, importShared, adopt, carry, describeMigration, migrationWarning and summary depend only on config. Each harness now keeps them in one typeConfig object that both its entries pass, so the screens' side has them where the service does not run. The retype preview becomes retypePreview, a pure function of an agent's config and the two types, which the service still uses. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Logan Johnson <loganj@squareup.com>
Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Logan Johnson <loganj@squareup.com>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
summaryin the agent list,defaults,adoptandcarryin the create dialog,importSharedin import, and the retype preview in Settings. Once the agents service runs in another page, screens need those functions on their own side.Details
AgentTypeConfigtype infeatures/agents/service.ts:defaults,importShared,adopt,carry,describeMigration,migrationWarningandsummary.AgentPresentationaccepts them, and the merge takes them frompresentlike the other screen fields.typeConfigobject, which bothregisterandpresentspread. The functions are moved, not changed.retypePreview(config, source, kind)is the retype preview as a pure function of the agent's config and the two types. The service'spreviewRetypestill uses it throughretypePlan. The message-port client from feat(agents): serve the agents service to screens over a MessagePort #1725 will use it to answerpreviewRetypeon the screens' side.docs/plugin-architecture.mddescribes which functions go to both calls.Testing
service.test.tscase: a type that passes its config functions only throughpresentshows them on the merged type, andretypePreviewgives the expected preview. It fails when the merge does not take config fields frompresent: I checked by mutating it.tsc --noEmitpasses. The agents feature suites and the Claude, Codex, goose, Pi and Agents page suites pass, except the Agents page avatar-picker test, which also fails on the base branch in my local tree.🤖 Generated with Claude Code