Repository navigation
feat(server): store divergences in Redis - #73
Merged
Merged
Conversation
alecthomas
marked this pull request as ready for review
October 28, 2026 08:48
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The SPECTRE server kept divergences only in memory, so a restart lost every reported quarantine and replicas could not share them. A storage interface keeps the in-memory behaviour as the default and lets the server use Redis when divergences must persist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alecthomas
force-pushed
the
feat/server-redis-storage
branch
2 times, most recently
from
October 28, 2026 10:09
66160ba to
b56086d
Compare
On a loaded runner the response comparison integration test ran past its one-minute deadline with no failed check, and the supervisor used most of its readiness timeout. The same code passed in under a minute elsewhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SPECTRE server kept divergences only in memory, so a restart lost every reported quarantine and several server replicas could not share them.
This puts storage behind an interface with two backends. Memory stays the default. Redis is selected with
--storage=redisand--redis-url. The server still validates reports and filters and sorts listings, so both backends only keep the latest quarantine of each mirror direction. The Redis backend keeps every divergence in one hash and uses an optimistic transaction so a stale retry never replaces a newer quarantine. Its tests run against an in-process Redis fake.It also gives the response comparison integration test more time. On a loaded CI runner it ran past its one-minute deadline without any check failing, so the overall deadline is now five minutes and the process readiness timeouts are 90 seconds.
🤖 Generated with Claude Code