Repository navigation
fix(adapters): reverse mapping views without list conversion - #1652
Closed
harshit-3355 wants to merge 7 commits into
Closed
harshit-3355 wants to merge 7 commits into
harshit-3355 wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
- Coverage 80.97% 80.97% -0.01%
==========================================
Files 198 198
Lines 20688 20692 +4
==========================================
+ Hits 16753 16755 +2
- Misses 3935 3937 +2
🚀 New features to boost your workflow:
|
2 tasks done
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use built-in reverse iteration for mapping items without first materializing an intermediate list. Normalize generic mapping views so one-shot cached views remain supported, and add a regression test for that behavior. Includes the required Unreleased changelog entry.
Closes #809
Verification
python -m pytest -q tests/adapters/test_mapping.pypasses.ruff check tiled/adapters/mapping.py tests/adapters/test_mapping.pypasses.git diff --checkpasses.Checklist