Repository navigation
fix(adapters): reverse mapping views without list conversion - #1656
Open
harshit3355 wants to merge 2 commits into
Open
harshit3355 wants to merge 2 commits into
harshit3355 wants to merge 2 commits into
Conversation
2 tasks done
harshit3355
force-pushed
the
fix/809-reverse-generic-mapping-items
branch
from
November 16, 2026 01:47
57722aa to
3706eff
Compare
harshit3355
force-pushed
the
fix/809-reverse-generic-mapping-items
branch
from
November 16, 2026 01:50
3706eff to
47db1a5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1656 +/- ##
=======================================
Coverage 81.00% 81.01%
=======================================
Files 198 198
Lines 20756 20760 +4
=======================================
+ Hits 16813 16818 +5
+ Misses 3943 3942 -1
🚀 New features to boost your workflow:
|
danielballan
requested changes
Nov 16, 2026
danielballan
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution! I left one small comment that I think needs to be addressed before we merge.
Author
|
Addressed in eef4b8f. The reversed mapping items view now uses a named intermediate, avoiding the shadowed assignment while keeping the no-list conversion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use built-in reverse iteration for mapping items without first materializing an intermediate list. Normalize generic mapping views so one-shot cached views remain supported, and add a regression test for that behavior. Includes the required Unreleased changelog entry.
Closes #809
Verification
python -m pytest -q tests/adapters/test_mapping.pypasses.ruff check tiled/adapters/mapping.py tests/adapters/test_mapping.pypasses.git diff --checkpasses.Checklist
Migration note: this contribution is now submitted from harshit3355; it replaces #1652, which was opened from a different GitHub account. Please close #1652 in favor of this PR.