Repository navigation
feat: Account for model memory and retain worker launch ownership - #835
Draft
buildingjoshbetter wants to merge 16 commits into
Draft
buildingjoshbetter wants to merge 16 commits into
buildingjoshbetter wants to merge 16 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local embedding and reranking could start allocations without a shared reservation, worker startup could lose ownership evidence across failures, and Qwen embedding calls retained unused decoder caches. This composition adds shared model memory accounting and launch ownership records, and disables decoder caches in the three Qwen embedding constructors. The original models, precision, padding, reranker and output contract remain unchanged. It also carries the previously tested ingestion, provenance and adapter reliability fixes.
Changes since 40928be:
CreateFileW/CreateDirectoryW). Existing objects are never repaired or adopted. POSIX paths are unchanged.unsafe_directoryinstead of recursing.permission-mode,last-prompt,cost-state,atis-latch,queue-operationandattachmentrecords. The coverage parser counted them as malformed, so ingestion completion of every real session stayed unproven and retried. Content-free metadata types are now non-conversation. Only attachments of 12 observed host-context types, and queued prompts already recorded as user turns, are skipped. Unknown attachment types still count as malformed, and unrecorded queued prompts are still captured. Found with a sandboxed real Claude Code 2.1.296 host using synthetic data.Validation at 001e8f1:
This remains a draft. The retained batch-32 versus batch-8 embedding comparison still fails its original numerical tolerance. Mask-derived position IDs were tested on MPS and do not change it. Full installed Mac retrieval, positive native-host extraction completion (no LLM provider available in the isolated host), the Linux capped service route activation and a hard Mac physical memory cap remain unqualified. The original 26.24 GB workload is not claimed fixed. Windows behavior is proven only by the hosted Windows checks on this head.
The complete code-only diff excludes README, public documentation, setup and compatibility guides, benchmark methodology and public benchmark results. No merges or releases.