Conversation
README now leads with the container path (generate-env → compose up → register → CLI/MCP) as the recommended first-run experience. The bare-metal development path is demoted to a development-only subsection with a platform-equivalence table covering macOS, Ubuntu/Debian and WSL2. First-time guidance no longer points at bare-metal setup. Closes bytefolk#109
评审:方向认可,但有 1 处必改错误 + 推荐路径的 2 个"照抄会失败"的缺口本轮为只读验证评审(由 QoderCN 执行),不构成 approve,也不会合并 —— 按 先说站得住的部分新写的 Compose 命令序列与
必改:新增 callout 的方向是反的
更根本的是:从上往下读,首次用户先撞见的仍然是 Go 1.25 / protoc / pgvector / Ollama 那张裸机清单,这恰好与本 PR 要满足的 AC-001(README 以容器路径开头)相反。建议把整段 推荐路径的准确性缺口
"这是经过运维验证的最短路径"声明范围偏大。 #109 中 ops 实测的闭环是 up → 首次注册 → 浏览器建目录;README 现在展示的 CLI + 语义检索链路不在被验证范围内。REQ-001 要的正是"用证据词汇陈述已验证闭环"——验证到哪步就只声明到哪步。AC-002(干净环境跑通并留证据)本 PR 尚未附证据。 平台等价表:REQ-002 的靶心,这里最值得补强Ubuntu 列少前置,Linux 新手第一步就撞墙。 我在这台 WSL2 Ubuntu 26.04 上实测 WSL2 列只写"同 Ubuntu"太薄。 至少两点是 WSL2 特有的:① 从 Windows 侧浏览器打开 小问题(顺手改)
流程门槛(交 maintainer 判断,我不代为决定)
结论结构重定位是对的、与 DEPLOYMENT.md 的一致性也好,值得往这个方向收。合并前建议至少处理:callout 方向(必改)、CLI 获取途径、compose 上的 AI 检索声明范围、Ubuntu 列的 PGDG 前置。AC-002 的干净环境证据(一次 |
|
Closing under the fork-workflow decision recorded on 2026-09-03: repository #109. A documentation reordering with no accompanying test, which is not itself a One thing worth carrying over, because it was correct and is easy to lose: this The commits are not lost. A closed fork PR keeps its head ref: git fetch https://github.com/bytefolk/mem.git refs/pull/148/head:pr-148Every file in this branch was therefore available to the re-doing work, whether |
Summary
deploy/composecontainer path as the recommended first-run experience (one-shot:generate-env→compose up→ register → CLI/MCP usage).scripts/dev_up.sh) demoted to a development-only subsection with a clear callout that it is for modifying mem source code, not for first-time users.Closes #109
Test plan
#通过-compose-启动推荐) resolve correctly