Repository navigation
Conversation
| When the request "{operationId}" is sent | ||
| Then the response status code is 400 | ||
| And the response header "Content-Type" is "application/json" | ||
| And the response header "x-correlator" has same value as the request header "x-correlator" |
There was a problem hiding this comment.
Please check this comment @camaraproject/commonalities_codeowners, cc @hdamker
Point to be discussed is about behaviour of x-correlator in response.
There was a problem hiding this comment.
The key is the following: in this test the value input for x-correlator is wrong, so as this could face issues in some API servers that can not allow that (that is, return the same invalid value).
There was a problem hiding this comment.
From TEF implementation, our API Server manages it and echoing the value is not an issue. Nonetheless, from our view this may be different, depending on how an implementation is performed this cannot be achieved (e.g. implementing logic in backend -resource-server-).
So we think the step of checking any specific consideration with regards to x-correlator can be omitted/removed
And the response header "x-correlator" has same value as the request header "x-correlator"
and let implementations to manage in the way it fits better in their architecture
There was a problem hiding this comment.
Honestly, this "And the response header "x-correlator" has same value as the request header "x-correlator"" does not make sense. The 400 status code is because of the wrongly formatted x-correlation and the wrongly formatted x-correlator value does not need to be echoed back (i.e. can be left to implementation). Thus, I suggest to remove that line here.
| And the response header "x-correlator" has same value as the request header "x-correlator" |
There was a problem hiding this comment.
Thanks for the comment! Makes sense Thorsten. Will wait a few days in case other views, and then I will apply the suggestion.
What type of PR is this?
What this PR does / why we need it:
This PR aims to cover missing response headers
x-correlatorandContent-Typein Commonalities Testing Artifacts.Additionally, also aligns the order of appearance of this checkings in tests design as per below:
Artifacts updated:
@{xxx}_subscriptions_03_subscription_creation_event_validation@{xxx}_subscriptions_10_subscription_delete_event_validation@{xxx}_subscriptions_11_subscription_creation_initial_event@{xxx}_subscriptions_2xseries@{xxx}_subscriptions_3xseries@{xxx}_subscriptions_4xseries@{xxx}_subscriptions_5xseries@{xxx}_subscriptions_6xseries@{xxx}_subscriptions_74@{xxx}_subscriptions_75400.06_invalid_x-correlator,429.01_Too_Many_Requests400.0x,401.0x,403.0x,404.01and409.0xscenariosWhich issue(s) this PR fixes:
Fixes #726
Does this PR introduce a breaking change?
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.