Add san-ip to the secrets value

[arif-ali]

This change fixes the fact that san-ip wasn't being added to the backend secrets, and hence would not apply the terraform.

Closes-bug: #2161683

QA steps

• Deploy a 1 node sunbeam
• bootstrap sunbeam
• Create a file called dellpowerstore.yaml, with the following contents

dell-powerstore:
    san-ip: "192.168.1.100"               # Management IP/FQDN of PowerStore array
    san-login: "admin"                   # PowerStore user
    san-password: "YourSecurePassword"   # PowerStore password
    protocol: "iscsi"                     # Options: iscsi or fc

• Run the following command

sunbeam storage add dellpowerstore dell-powerstore --config-file dellpowerstore.yaml

This will run to completion if all is good

• you should be able to run sunbeam storage show dell-powerstore, which should show the output

                            Configuration for Dell PowerStore backend 'dell-powerstore'                            
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Option                         ┃ Value                     ┃ Description                                        ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ san-ip                         │ ********                  │ Dell PowerStore management IP                      │
│ san-login                      │ *****                     │ Dell PowerStore management username                │
│ san-password                   │ ********                  │  Dell PowerStore management password               │
│ protocol                       │ fc                        │ Storage protocol (fc or iscsi)                     │
└────────────────────────────────┴───────────────────────────┴────────────────────────────────────────────────────┘

Links

Jira card: OPEN-4685

[Raven-182]

Thanks for this.

nit: test_dellpowerstore.py has a test_dellpowerstore_san_credentials_are_secret test that checks the SecretDictField marker for san_login and san_password. We should add an assertion for the san_ip field as well

[gboutry]

Are drivers hiding the IP?

Or is it the only one?

That would change if we need to update the charm or the snap.

Do we consider the ip a value to mask (and store in a juju secret)?

Please follow conventional commits.