Skip to content

Add san-ip to the secrets value #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arif-ali wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add san-ip to the secrets value #917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sunbeam-python/sunbeam/storage/backends/dellpowerstore/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class DellPowerstoreConfig(StorageBackendConfig):
san_ip: Annotated[
str,
Field(description="Dell PowerStore management IP"),
SecretDictField(field="san-ip"),
]
san_login: Annotated[
str,
Expand Down
9 changes: 9 additions & 0 deletions sunbeam-python/tests/unit/sunbeam/storage/backends/test_dellpowerstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,15 @@ def test_dellpowerstore_san_credentials_are_secret(self, backend):

config_class = backend.config_type()

# Check san_ip is marked as secret
ip_field = config_class.model_fields.get("san_ip")
assert ip_field is not None
has_secret_marker = any(
isinstance(m, SecretDictField) for m in ip_field.metadata
)

assert has_secret_marker, "san_ip` should be marked as secret"

# Check san_login is marked as secret
username_field = config_class.model_fields.get("san_login")
assert username_field is not None
Expand Down
Loading