Repository navigation
refactor: host migration state, plan entries and SQL-test planning in Rust - #1109
Merged
Merged
Conversation
Move SQL-test cursor window validation and intrinsic rendering into the native SQL-test glue and delete the Python cursor window and comment-scanning helpers. Test helpers now read logical references through the native reference extractor.
Move the planner's migration state inspection and the shared read and append orchestration of migration, column migration and old-name view events into one native owner. Adapter execute and metadata calls remain Python callbacks; event IDs, idempotent appends, retries and absent column tolerance are unchanged. Delete the replaced Python wrappers and the create-table SQL facades.
Move model plan entry assembly into native code: cursor input relations, cursor input column validation, runtime cursor producers, microbatch lookback defaults, seed column extraction, adapter-rendered logical DDL and the ModelPlanEntry construction. Python keeps cursor bound, hook and SQL resolution and calls the native assembly.
Move configured microbatch limit precedence and per-entry limit application into native code, and resolve the effective timestamp grain for default lookbacks inside native model entry assembly. The Python limit helpers are deleted and their tests call the native functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Continue Rust-hosted planning while preserving migration state formats, SQL artifacts, adapter overrides and plan output.
Changes
Verification