Skip to content

chore: update OpenAPI to d35bb4402f38 - #430

Merged
petebacondarwin merged 1 commit into
mainfrom
automation/update-forge
Oct 28, 2026
Merged

petebacondarwin merged 1 commit into
mainfrom
automation/update-forge

Conversation

@ant-release-bot

@ant-release-bot ant-release-bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Updates cf to openapi@d35bb4402f3864b83e802be14ca7f58eb920528b.

  • pins OpenAPI revision d35bb4402f3864b83e802be14ca7f58eb920528b
  • regenerates the committed command surface with the pinned Forge package

This PR is maintained automatically by the Update OpenAPI workflow.

@ant-release-bot
ant-release-bot requested a review from a team as a code owner October 27, 2026 12:47
@pkg-pr-new

pkg-pr-new Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/cf@430

commit: cc21d08

@ask-bonk

ask-bonk Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@clanky-the-clanker

clanky-the-clanker Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

💬 Approved with comments — A clean regenerated pin bump with a correct changeset, and the earlier bulk-delete array-flag issue is fixed. The only note is an INFO that most generated files were not checked individually.

Findings: 1 info

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


📋 Code Quality: 💬 1 info

The earlier bulk-delete array-flag warning is resolved; most generated files were not checked individually.

Recommendation: 💬 Optional Nits

  • [INFO] Not checked individually for correctness: most of the regenerated files, including _meta/commands.json, _meta/schemas.json, the new _operations/* modules (payload-logging, trust-settings, nameserver-sets edit, basin-catalog/r2-data-catalog enable, reporting industry get), the new payload-logging, trust-settings and nameserver-sets edit command files, and the url-scanner/scans/create.ts rewrite.
View full review

The earlier WARNING about --indicator-ids is resolved.

  • bulk-delete.ts:31-36 now declares the flag as type: "string", array: true.
  • The array is passed to the client as-is.
  • The operation has no joined entry, so fetch.ts sends each value as a repeated indicatorIds= key.

Most of the other regenerated files were not checked individually.


✅ All other checks passed

🚀 Release: ✅ LGTM

Risk: Low. The "cf": minor changeset is correct for new commands and flags.


🔒 Security: ✅ LGTM

No new auth handling, secret handling or ad-hoc fetches. The pin bump and the removed modules only change generated output.


📖 AGENTS.md: ✅ LGTM

The output was regenerated rather than hand-edited, and a changeset is included.


⚡ Performance: ✅ LGTM

New roots are registered through the existing lazy generated index.


📝 Documentation: ✅ LGTM

Command descriptions come from the upstream OpenAPI document.


Reviewed commit: cc21d085

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

cf --help startup

mean stddev min max
PR 289.6 ms 3.6 ms 282.3 ms 295.9 ms
base 291.5 ms 4.6 ms 279.5 ms 299.9 ms

Δ (PR vs base): ↓ -1.9 ms (-0.6%)

Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 8db8d036ebbf chore: update OpenAPI to 49d6810e17f7 Oct 27, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from a624dcc to 4ae252b Compare October 27, 2026 14:40
@ask-bonk

ask-bonk Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 49d6810e17f7 chore: update OpenAPI to 904e0d92dbc5 Oct 27, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from 4ae252b to d65d0ae Compare October 27, 2026 15:37
Comment thread .changeset/update-openapi-904e0d92dbc5.md Outdated
@ask-bonk

ask-bonk Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review: 1 findings.
Posted 1 inline suggestion.

github run

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 904e0d92dbc5 chore: update OpenAPI to 04aa07b5bda6 Oct 27, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from d65d0ae to 08b6f48 Compare October 27, 2026 16:31
@ask-bonk

ask-bonk Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

🤖 I've done a thorough review of your PR.

Updates the pinned Forge OpenAPI revision and regenerates the CLI command surface.

  1. Warning: .changeset/update-openapi-04aa07b5bda6.md:5 omits user-visible behavioral changes. Updated the existing ask-bonk suggestion to document the required nameserver-set name, newly visible roots, and narrowed country choices.

github run

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 04aa07b5bda6 chore: update OpenAPI to 74ede52d9f2b Oct 27, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from 08b6f48 to a4b9d95 Compare October 27, 2026 17:28
@ask-bonk

ask-bonk Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review: 1 findings.
🤖 I've done a thorough review of your PR.

Updates the Forge OpenAPI revision and regenerated command surface.

  1. Warning: Updated the existing ask-bonk suggestion to document omitted user-visible behavior changes in the changeset.

github run

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 74ede52d9f2b chore: update OpenAPI to ab4c287fe57e Oct 27, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from a4b9d95 to 77d4574 Compare October 27, 2026 18:31
@ask-bonk

ask-bonk Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review: 1 findings.

Updates the OpenAPI pin and regenerated CLI surface. Updated 1 existing inline suggestion.

github run

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to ab4c287fe57e chore: update OpenAPI to 67443a2de555 Oct 27, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from 77d4574 to bc55574 Compare October 27, 2026 19:27
@ask-bonk

ask-bonk Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

🤖 I've done a thorough review of your PR.

Updates the Forge OpenAPI pin and regenerates the CLI surface.

  1. Warning: Updated the existing changeset suggestion to document the user-visible command and behavior changes.

github run

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 67443a2de555 chore: update OpenAPI to 335cc3435d06 Oct 27, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from bc55574 to 4ff1b59 Compare October 27, 2026 20:28
@ask-bonk

ask-bonk Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

🤖 I've done a thorough review of your PR.

Updates the pinned Forge OpenAPI revision and regenerated CLI surface.

  1. Warning: Updated the existing suggestion to document user-visible release changes omitted from the changeset.

github run

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 335cc3435d06 chore: update OpenAPI to 5ea4fd49a392 Oct 27, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from 4ff1b59 to ba2b19e Compare October 27, 2026 21:27
@ask-bonk

ask-bonk Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review: 1 findings.

Posted 1 inline suggestion.

github run

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 5ea4fd49a392 chore: update OpenAPI to d35bb4402f38 Oct 28, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from ba2b19e to 7d97c0e Compare October 28, 2026 08:34
@ask-bonk

ask-bonk Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

No new concerns since the last review

github run

@ask-bonk

ask-bonk Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

No new concerns since the last review

github run

@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from 64cd952 to cc21d08 Compare October 28, 2026 12:13
Comment thread .changeset/update-openapi-d35bb4402f38.md
@ask-bonk

ask-bonk Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

🤖 I've done a thorough review of your PR.

Updates the Forge OpenAPI pin and regenerates the CLI command surface.

  1. Warning: Posted an inline suggestion to add the required explanatory changeset body.

github run

@petebacondarwin
petebacondarwin added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit b53a8be Oct 28, 2026
12 checks passed
@petebacondarwin
petebacondarwin deleted the automation/update-forge branch October 28, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants