Repository navigation
fix: preserve arrays in generated query flags - #436
Conversation
commit: |
|
LGTM |
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 223.4 ms | 5.0 ms | 214.1 ms | 232.6 ms |
| base | 219.8 ms | 4.3 ms | 213.8 ms | 229.4 ms |
Δ (PR vs base): ↑ +3.5 ms (+1.6%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
|
💬 Approved with comments — No issues found: the generator fix is small and covered by tests, and the regenerated output only adds Findings: 1 info The decision is advisory: this comment never approves, blocks or requests changes on the pull request. 📋 Code Quality: 💬 1 infoNo defects found; most regenerated files were not read one by one Recommendation: 💬 Optional Nits
View full reviewThe Coverage: a sample of the regenerated files was read in full, including the generator change, ✅ All other checks passed🚀 Release: ✅ LGTMRisk: Low. The 🔒 Security: ✅ LGTMThe change only adds the 📖 AGENTS.md: ✅ LGTMThe change follows repository conventions: a generator plugin fix plus regenerated output with no hand edits, and a patch changeset for a user-facing fix. ⚡ Performance: ✅ LGTMNo performance concerns. 📝 Documentation: ✅ LGTMThe Reviewed commit: |
Array query parameters were emitted as scalar string options, so
--ids first secondfailed yargs validation and a single value parsed as a string. Preserve the array type during query argument derivation so the existing builder emitsarray: true.Validation:
pnpm checkand 122 focused generator/API tests pass. The regression tests fail before the fix for single and grouped values.Addresses the generator issue identified in the review of #430. That OpenAPI update can regenerate its new command with this fix after it lands.