Repository navigation
fix(wrangler): skip banner when using --json flag in wrangler pages deployment commands - #10822
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f2dd2be The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
edmundhung
force-pushed
the
edmundhung/disable-banner-on-json-output
branch
from
September 30, 2025 16:05
e17a904 to
cf4cba9
Compare
edmundhung
marked this pull request as ready for review
September 30, 2025 16:06
edmundhung
force-pushed
the
edmundhung/disable-banner-on-json-output
branch
from
September 30, 2025 16:14
cf4cba9 to
e9edc08
Compare
edmundhung
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
edmundhung
force-pushed
the
edmundhung/disable-banner-on-json-output
branch
from
October 1, 2025 12:17
e9edc08 to
f2dd2be
Compare
petebacondarwin
approved these changes
Oct 1, 2025
| import type { Deployment } from "./../../pages/types"; | ||
|
|
||
| describe("pages deployment list", () => { | ||
| vi.unmock("../../wrangler-banner"); |
Contributor
There was a problem hiding this comment.
I wonder if we should unmock print banner across all the tests?
Member
Author
There was a problem hiding this comment.
Yes. That's my plan next after all these PRs. It's really tricky to catch this when we have it mocked by default, especially when the command is done by external team.
But it would probably be a huge PR as it will likely impact a fair amount of snapshots test we had.
This comment was marked as outdated.
This comment was marked as outdated.
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes n/a.