Repository navigation
[vite-plugin] Backport caller-owned Container guidance to v1 - #16334
petebacondarwin wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 1319581 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dario-piotrowicz (author of #16225) and @edmundhung (verified human ant-core approver), could you please check this The adaptation preserves v1's per-Worker Container planning and legacy configuration filenames while passing caller-owned registry guidance from both dev and preview. Public Container/deployment helper source stays absent; the manifests pin the pending releases instead. Earlier backport #16333 supplies the coupled Miniflare, Wrangler, and runtime-types versions, without repeating or reverting those bumps here. This draft awaits npm publication and final dependency/build/type/test validation, as detailed in the description. |
3866994 to
1319581
Compare
Backport #16225 to Vite plugin v1, stacked on #16333 (the October 16 runtime backport). The stack ultimately targets
vite-plugin-v1.Pass command guidance directly to the Container helper from both Vite dev and preview. Preserve v1's per-Worker image planning: legacy configurations use their actual configuration filename (preview uses its generated
wrangler.json), while programmatic configuration usescloudflare.config.ts. Preserve the experimental cf delegate's existing CLI identity when choosing the registry command.Pin public containers-shared to
0.23.0in the plugin and deploy-helpers to0.22.0in retained private remote-bindings, as recorded in the pending main release #16313. No absent public package source is restored. Private support packages and allworkspace:*references remain intact. The parent supplies the coupled Miniflare/Wrangler/runtime-types updates; this PR does not repeat or revert them. This original has its own source adaptation, regression tests, and plugin patch changeset.Validation on Node.js 22.22.1 / pnpm 10.33.0:
Publication blocker: npm returns 404 for containers-shared
0.23.0and deploy-helpers0.22.0; the parent also awaits Miniflare5.20261016.0-beta, Wrangler4.151.2, and runtime-types0.1.13. Full lockfile resolution fails withERR_PNPM_NO_MATCHING_VERSION; no generated lockfile entries are invented. A provisional plugin type check against installed containers-shared0.22.1reports the expected missingconfigFileNameAPI, which the pinned0.23.0introduces. Final build/type/test validation and frozen CI installation remain blocked until publication. After updating and validating the parent lockfile, rebase this PR, regenerate/install the lockfile for these two pins, and run build, types, all relevant tests, and cross-platform CI before marking ready.Maintenance check (2026-10-18): all listed pending package versions still return npm 404. Rebased the two-PR stack onto current
vite-plugin-v1(5d6b32dd6); each patch is unchanged by range-diff and each resulting file tree is byte-identical to its previously validated head. All 73 private manifests and 107 workspace references are preserved. Prior provisional test results above remain applicable; final dependency/build/type/test validation remains blocked on publication.Note
This is a contribution from an AI agent: Codex, GPT-6, preparing maintainer-requested v1 backports.