Skip to content

[vite-plugin] Backport caller-owned Container guidance to v1 - #16334

Draft
petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16307from
codex/vite-v1-backport-16225
Draft

petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16307from
codex/vite-v1-backport-16225

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Backport #16225 to Vite plugin v1, stacked on #16333 (the October 16 runtime backport). The stack ultimately targets vite-plugin-v1.

Pass command guidance directly to the Container helper from both Vite dev and preview. Preserve v1's per-Worker image planning: legacy configurations use their actual configuration filename (preview uses its generated wrangler.json), while programmatic configuration uses cloudflare.config.ts. Preserve the experimental cf delegate's existing CLI identity when choosing the registry command.

Pin public containers-shared to 0.23.0 in the plugin and deploy-helpers to 0.22.0 in retained private remote-bindings, as recorded in the pending main release #16313. No absent public package source is restored. Private support packages and all workspace:* references remain intact. The parent supplies the coupled Miniflare/Wrangler/runtime-types updates; this PR does not repeat or revert them. This original has its own source adaptation, regression tests, and plugin patch changeset.

Validation on Node.js 22.22.1 / pnpm 10.33.0:

  • All 27 relevant tests pass against the existing installed published dependencies, temporarily restoring the parent publication pins only for that provisional test run. Coverage includes real Vite dev/preview server integration, three direct guidance regressions, per-Worker registry setup, and Build Output Containers. All intended manifest pins are restored in the commit.
  • All three new guidance cases fail against the unadapted parent source, then pass with this adaptation.
  • Changed-source type-aware lint, formatting, changeset validation, workspace-reference checks, and whitespace checks pass.

Publication blocker: npm returns 404 for containers-shared 0.23.0 and deploy-helpers 0.22.0; the parent also awaits Miniflare 5.20261016.0-beta, Wrangler 4.151.2, and runtime-types 0.1.13. Full lockfile resolution fails with ERR_PNPM_NO_MATCHING_VERSION; no generated lockfile entries are invented. A provisional plugin type check against installed containers-shared 0.22.1 reports the expected missing configFileName API, which the pinned 0.23.0 introduces. Final build/type/test validation and frozen CI installation remain blocked until publication. After updating and validating the parent lockfile, rebase this PR, regenerate/install the lockfile for these two pins, and run build, types, all relevant tests, and cross-platform CI before marking ready.

Maintenance check (2026-10-18): all listed pending package versions still return npm 404. Rebased the two-PR stack onto current vite-plugin-v1 (5d6b32dd6); each patch is unchanged by range-diff and each resulting file tree is byte-identical to its previously validated head. All 73 private manifests and 107 workspace references are preserved. Prior provisional test results above remain applicable; final dependency/build/type/test validation remains blocked on publication.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this preserves existing v1 guidance while adapting internal shared-helper APIs.

Note

This is a contribution from an AI agent: Codex, GPT-6, preparing maintainer-requested v1 backports.

@petebacondarwin petebacondarwin added blocked Blocked on other work dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package labels Oct 17, 2026
@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1319581

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@dario-piotrowicz (author of #16225) and @edmundhung (verified human ant-core approver), could you please check this vite-plugin-v1 backport and approve it when it is ready and looks good?

The adaptation preserves v1's per-Worker Container planning and legacy configuration filenames while passing caller-owned registry guidance from both dev and preview. Public Container/deployment helper source stays absent; the manifests pin the pending releases instead. Earlier backport #16333 supplies the coupled Miniflare, Wrangler, and runtime-types versions, without repeating or reverting those bumps here. This draft awaits npm publication and final dependency/build/type/test validation, as detailed in the description.

@petebacondarwin
petebacondarwin force-pushed the codex/vite-v1-backport-16225 branch from 3866994 to 1319581 Compare October 18, 2026 12:57
@petebacondarwin
petebacondarwin added this pull request to stack #16347 October 18, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Blocked on other work dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant