Repository navigation
[vite-plugin] Backport October 16 runtime updates to v1 - #16333
petebacondarwin wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 3765be4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dependabot[bot] (recorded bot author of #16307) and @edmundhung (verified human ant-core approver), could you please check this The v1 adaptation consumes the public runtime packages instead of restoring their source, pins Miniflare in retained private consumers, and adds the encoded-asset regression plus runtime-type coverage. The draft awaits the Miniflare, Wrangler, and runtime-types publication listed in the description; final lockfile/build/type/test validation must follow. This PR supplies its own dependency versions and remains separate from the Container guidance follow-up #16334. |
64a6688 to
530e2f0
Compare
commit: |
|
Codeowners approval required for this PR:
|
|
|
||
| Update the local Workers runtime to include the October 16 fixes | ||
|
|
||
| Use the matching Miniflare, workerd, Wrangler, and runtime type generator releases. The combined October 19 release includes these fixes for nested asset paths on Windows; its runtime and types also supply the later runtime backport. |
There was a problem hiding this comment.
🟡 Changeset obscures the user-facing fix
For users reading the changelog, Use the matching Miniflare describes release coordination instead of the local-development benefit. The changeset rule requires user-facing impact rather than maintainer implementation details.
| Use the matching Miniflare, workerd, Wrangler, and runtime type generator releases. The combined October 19 release includes these fixes for nested asset paths on Windows; its runtime and types also supply the later runtime backport. | |
| Nested assets with encoded filenames now load correctly during local development on Windows. Runtime types also reflect the updated Workers runtime. |
Was this helpful? React with 👍 or 👎 to provide feedback.
|
✅ Approved — No issues found. The dependency pins move together as one consistent released set (Miniflare 5.20261019.0-beta, workerd 1.20261019.1, Wrangler 4.151.2, runtime-types 0.1.13, Workers types 5.20261019.1), private workspace references are unchanged, and the new regression test covers encoded nested asset paths. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed🚀 Release: ✅ LGTMRisk: Low. This is a patch changeset for 🔒 Security: ✅ LGTMNo security concerns. The change only bumps exact versions of published dependencies and adds tests. 📖 AGENTS.md: ✅ LGTMThe change follows the branch guidance. Public SDK packages are pinned to exact npm versions, private dependencies stay as 📋 Code Quality: ✅ LGTMNo issues found. The new ⚡ Performance: ✅ LGTMNo performance concerns. 📝 Documentation: ✅ LGTMThe changeset clearly describes what users will notice: encoded nested asset filenames now load on Windows, and runtime types are updated. Reviewed commit: |
Backport #16307 to Vite plugin v1, fixing nested encoded asset paths during local development on Windows and updating runtime type generation. This PR is based on
vite-plugin-v1; #16334, #16354 (original #16352), and #16355 (release #16313) stack above it.The October 16 changes shipped with the October 19 update in release #16313; Miniflare
5.20261016.0-betawas never published. Pin the released Miniflare5.20261019.0-beta, Wrangler4.151.2, runtime-types0.1.13, workerd1.20261019.1, and Workers types5.20261019.1together here because Wrangler and runtime-types require that Miniflare/workerd pair. Pin Miniflare consistently in the plugin, private remote-bindings, and the retained account-id fixture; update the Workers types catalog for private consumers. Each later original retains its own tests and changeset without repeating these versions.The regression exercises encoded nested assets and runtime-type generation/cache behavior against published dependencies. Private packages and workspace references remain intact, and public sibling source remains absent. This PR's build, 275 plugin tests, and 60 repository checks passed against the released graph; its release-note wording also passes the final stack checks.
Final stack validation on Node.js 22.22.1 / pnpm 10.33.0: offline frozen installation, build (3 tasks), all retained unit tasks (8 tasks, 285 plugin tests), and all repository checks (60 tasks) pass. Cross-platform CI and maintainer review remain required.
Note
This is a contribution from an AI agent: Codex, GPT-6, preparing maintainer-requested v1 backports.