Skip to content

[vite-plugin] Backport October 16 runtime updates to v1 - #16333

Open
petebacondarwin wants to merge 3 commits into
vite-plugin-v1from
codex/vite-v1-backport-16307
Open

petebacondarwin wants to merge 3 commits into
vite-plugin-v1from
codex/vite-v1-backport-16307

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Backport #16307 to Vite plugin v1, fixing nested encoded asset paths during local development on Windows and updating runtime type generation. This PR is based on vite-plugin-v1; #16334, #16354 (original #16352), and #16355 (release #16313) stack above it.

The October 16 changes shipped with the October 19 update in release #16313; Miniflare 5.20261016.0-beta was never published. Pin the released Miniflare 5.20261019.0-beta, Wrangler 4.151.2, runtime-types 0.1.13, workerd 1.20261019.1, and Workers types 5.20261019.1 together here because Wrangler and runtime-types require that Miniflare/workerd pair. Pin Miniflare consistently in the plugin, private remote-bindings, and the retained account-id fixture; update the Workers types catalog for private consumers. Each later original retains its own tests and changeset without repeating these versions.

The regression exercises encoded nested assets and runtime-type generation/cache behavior against published dependencies. Private packages and workspace references remain intact, and public sibling source remains absent. This PR's build, 275 plugin tests, and 60 repository checks passed against the released graph; its release-note wording also passes the final stack checks.

Final stack validation on Node.js 22.22.1 / pnpm 10.33.0: offline frozen installation, build (3 tasks), all retained unit tasks (8 tasks, 285 plugin tests), and all repository checks (60 tasks) pass. Cross-platform CI and maintainer review remain required.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this maintains existing v1 behavior with compatible released SDK dependencies.

Note

This is a contribution from an AI agent: Codex, GPT-6, preparing maintainer-requested v1 backports.

@petebacondarwin petebacondarwin added blocked Blocked on other work dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package labels Oct 17, 2026
@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3765be4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@dependabot[bot] (recorded bot author of #16307) and @edmundhung (verified human ant-core approver), could you please check this vite-plugin-v1 backport and approve it when it is ready and looks good?

The v1 adaptation consumes the public runtime packages instead of restoring their source, pins Miniflare in retained private consumers, and adds the encoded-asset regression plus runtime-type coverage. The draft awaits the Miniflare, Wrangler, and runtime-types publication listed in the description; final lockfile/build/type/test validation must follow. This PR supplies its own dependency versions and remains separate from the Container guidance follow-up #16334.

Base automatically changed from codex/vite-v1-backport-16287 to vite-plugin-v1 October 17, 2026 14:50
@petebacondarwin
petebacondarwin force-pushed the codex/vite-v1-backport-16307 branch from 64a6688 to 530e2f0 Compare October 18, 2026 12:57
@petebacondarwin
petebacondarwin added this pull request to stack #16347 October 18, 2026 14:03
@petebacondarwin petebacondarwin removed the blocked Blocked on other work label Oct 19, 2026
@petebacondarwin
petebacondarwin marked this pull request as ready for review October 19, 2026 10:56
@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16333

commit: 3765be4

@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread .changeset/v1-runtime-20261016.md Outdated

Update the local Workers runtime to include the October 16 fixes

Use the matching Miniflare, workerd, Wrangler, and runtime type generator releases. The combined October 19 release includes these fixes for nested asset paths on Windows; its runtime and types also supply the later runtime backport.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changeset obscures the user-facing fix

For users reading the changelog, Use the matching Miniflare describes release coordination instead of the local-development benefit. The changeset rule requires user-facing impact rather than maintainer implementation details.

Suggested change
Use the matching Miniflare, workerd, Wrangler, and runtime type generator releases. The combined October 19 release includes these fixes for nested asset paths on Windows; its runtime and types also supply the later runtime backport.
Nested assets with encoded filenames now load correctly during local development on Windows. Runtime types also reflect the updated Workers runtime.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@clanky-the-clanker

clanky-the-clanker Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Approved — No issues found. The dependency pins move together as one consistent released set (Miniflare 5.20261019.0-beta, workerd 1.20261019.1, Wrangler 4.151.2, runtime-types 0.1.13, Workers types 5.20261019.1), private workspace references are unchanged, and the new regression test covers encoded nested asset paths.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Risk: Low. This is a patch changeset for @cloudflare/vite-plugin. The Wrangler peer range moves to ^4.151.2 to match the pinned dependency, and the Miniflare pins in the plugin, remote-bindings and the account-id fixture all match.


🔒 Security: ✅ LGTM

No security concerns. The change only bumps exact versions of published dependencies and adds tests.


📖 AGENTS.md: ✅ LGTM

The change follows the branch guidance. Public SDK packages are pinned to exact npm versions, private dependencies stay as workspace:*, and a plugin changeset is included.


📋 Code Quality: ✅ LGTM

No issues found. The new runtime-assets.spec.ts test uses Vitest's test-context expect, a real temporary directory, node: imports and onTestFinished cleanup, which matches the repository's conventions.


⚡ Performance: ✅ LGTM

No performance concerns.


📝 Documentation: ✅ LGTM

The changeset clearly describes what users will notice: encoded nested asset filenames now load on Windows, and runtime types are updated.


Reviewed commit: 3765be4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants