Repository navigation
[vite-plugin] Backport October 19 runtime updates to v1 - #16354
petebacondarwin wants to merge 2 commits into
Conversation
petebacondarwin
added
dependencies
🦋 Changeset detectedLatest commit: 2854c34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
|
|
@dependabot[bot] (recorded bot author of #16352) and @petebacondarwin (verified human ant-core approver), could you please check this The combined SDK release required the October 19 runtime/types upgrades to land with the October 16 fixes, so earlier backport #16333 supplies the coupled dependency versions. This separate stacked backport preserves #16352's own plugin changeset and a real Miniflare regression for Node.js crypto and streamed responses at compatibility date |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| const miniflare = new Miniflare({ | ||
| workers: [ | ||
| { | ||
| config: { | ||
| name: "october-19-runtime", | ||
| compatibilityDate: "2026-10-19", | ||
| compatibilityFlags: ["nodejs_compat"], | ||
| manifest: { |
There was a problem hiding this comment.
🔍 Runtime coverage stops before plugin integration
The regression dispatches through Miniflare directly and never loads cloudflare(). It cannot detect failures in how the plugin passes compatibility settings to the runtime.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
✅ Approved — This is a small backport: a patch changeset plus one Miniflare regression test for the October 19 runtime. No issues found in either file. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed📋 Code Quality: ✅ LGTMThe new 📝 Documentation: ✅ LGTMThe Reviewed commit: |
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
d911fb2 to
98b8c2f
Compare
cddb5db to
2854c34
Compare
3 participants
Backport #16352 to Vite plugin v1, stacked on #16334. Preserve this original's separate runtime regression and plugin patch changeset; #16333 already supplies the compatible October 19 runtime versions.
The real installed-Miniflare regression exercises POST request bodies, Node.js crypto, and streamed responses at compatibility date
2026-10-19. The separate release backport #16355 also exercises the built plugin in real dev and preview servers at this date. #16333 supplies workerd1.20261019.1, Workers types5.20261019.1, Miniflare5.20261019.0-beta, and coupled Wrangler/runtime-types versions, including the retained private Workers types catalog. The October 16 and October 19 upgrades shipped together in release #16313, so no dependency bump is repeated or reverted here.Original autoconfig/codemods additions and workers-utils generated default-date source are absent from v1 and are not restored. Retained private packages and workspace references remain intact. The changeset describes the local runtime behavior; dependency sequencing is recorded in this description.
Final stack validation on Node.js 22.22.1 / pnpm 10.33.0: offline frozen installation, build (3 tasks), all retained unit tasks (8 tasks, 285 plugin tests), and all repository checks (60 tasks) pass. Cross-platform CI and maintainer review remain required.
Note
This is a contribution from an AI agent: Codex, GPT-6, preparing maintainer-requested v1 backports.