Skip to content

[vite-plugin] Backport October 19 SDK release to v1 - #16355

Closed
petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16352from
codex/vite-v1-backport-16313
Closed

petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16352from
codex/vite-v1-backport-16313

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Backport the compatible SDK release from #16313 to Vite plugin v1, stacked on #16354 (the separate #16352 runtime backport), above #16334 and #16333. The stack ultimately targets vite-plugin-v1.

Miniflare 5.20261019.0-beta is supplied consistently by #16333 in the plugin, private remote-bindings, and the retained account-id fixture. That earliest necessary backport also supplies coupled Wrangler 4.151.2, runtime-types 0.1.13, workerd 1.20261019.1, and Workers types 5.20261019.1; #16334 supplies containers-shared 0.23.0 and deploy-helpers 0.22.0. All are published and the preceding lockfiles are regenerated. No dependency bump is repeated or reverted here.

Preserve a separate release backport with its own plugin patch changeset and real dev/preview tests importing the built v1 plugin. The tests verify Wrangler configuration parsing, Miniflare startup, Worker bindings, request routing, and generated preview output at the release's compatibility date. V1's changeset workflow generates its release metadata. Private packages and workspace references remain intact; absent public sibling source and v2 release metadata are not restored.

Final validation on Node.js 22.22.1 / pnpm 10.33.0: offline frozen installation, build (3 tasks), all retained unit tasks (8 tasks, 285 plugin tests), and all repository checks (60 tasks) pass. This includes both built-plugin release smoke tests, the installed-runtime regression, and the inline Container dev/preview regressions. Cross-platform CI and maintainer review remain required.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this maintains existing v1 behavior with compatible released SDK dependencies.

Note

This is a contribution from an AI agent: Codex, GPT-6, preparing maintainer-requested v1 backports.

@petebacondarwin petebacondarwin added dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package labels Oct 19, 2026
@changeset-bot

changeset-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f7f2d26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
workers-devprod requested review from a team and NuroDev and removed request for a team October 19, 2026 10:57
@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@workers-devprod (recorded release automation author of #16313, account name ANT Bot) and @petebacondarwin (verified human ant-core approver), could you please check this vite-plugin-v1 backport and approve it if it looks good?

This release keeps its own plugin changeset and real built-plugin dev/preview regression tests. Earlier backport #16333 supplies Miniflare 5.20261019.0-beta and its coupled Wrangler, workerd, Workers types, and runtime-types versions; #16334 supplies the Container/deployment helper versions. The dependencies are published and lockfiles regenerated, with build, all unit tests, and repository checks passing locally. Cross-platform CI is running. No v2 release metadata or absent public source is restored.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@clanky-the-clanker

clanky-the-clanker Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Approved — No issues found. The patch changeset for @​cloudflare/vite-plugin and the new dev/preview smoke test against the built plugin follow the repository's conventions.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

I found nothing to flag in this change.

  • Build ordering: sdk-release.spec.ts imports the built plugin from ../../dist/index.mjs. In the root turbo.json, test and test:ci depend on build, so dist exists when the test runs.
  • Test setup: The test uses runInTempDir, writes real files and takes expect from the test context, as the repository's instructions ask. The dev and preview cases each run in their own temporary directory.
  • Cleanup: onTestFinished closes the server and restores the stubbed environment variables. Vitest runs these hooks in reverse order, so the cleanup order is correct.
  • Changeset: It is a patch changeset for @cloudflare/vite-plugin, which matches the plugin changeset guidance.

📝 Documentation: ✅ LGTM

The changeset accurately describes the backported SDK release. No documentation changes are needed.


Reviewed commit: f7f2d263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Used by dependabot to mark PRs as updates to dependencies. package:vite-plugin Relating to the `@cloudflare/vite-plugin` package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants