Repository navigation
[vite-plugin] Use Vitest 5 in v1 maintenance tests - #16378
petebacondarwin wants to merge 1 commit into
Conversation
|
|
@NuroDev (recorded author of #16259) and @petebacondarwin (verified human ant-core approver), could you please check this Vite plugin v1 backport and approve it if it looks good? The remaining v1 change migrates retained asset/router workers and plugin tests to Vitest 5 using the published test plugin. Shared helper pins are coupled to keep Vitest peers and the retained remote-binding upload types compatible. Earlier #16333 supplies the runtime upgrade; this PR stacks on #16373. Removed public package source, tests, and C3 templates stay absent. |
|
Codeowners approval required for this PR:
|
|
✅ Approved — No issues found. The Vitest 5 and @cloudflare/vitest-plugin migration and the helper version bumps match each other and the lockfile. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed🚀 Release: ✅ LGTMRisk: Low. Leaving out a plugin changeset is reasonable, since the change does not alter any user-facing plugin behaviour. 🔒 Security: ✅ LGTMNo security issues found. The change only touches test tooling and pinned dependency versions. 📖 AGENTS.md: ✅ LGTMThe change follows the repository guidelines: private workspace references are kept, and public SDK packages are pinned to exact npm versions. 📋 Code Quality: ✅ LGTMNo issues found. What was checked:
⚡ Performance: ✅ LGTMNo performance issues found. 📝 Documentation: ✅ LGTMNo documentation changes are needed. The change is limited to internal test tooling and compatible helper versions. Reviewed commit: |
Backport the useful remaining parts of #16259 to the Vite plugin v1 maintenance workspace. Run the retained asset/router workers and plugin tests with Vitest 5.0.4, replace the old published vitest-pool-workers test runner with published @cloudflare/vitest-plugin 1.4.3, and keep the remote-binding and React SPA tests sequential using Vitest 5's supported options.
Preserve all retained private packages and workspace:* references. Update pinned workers-utils to 0.47.3 and workers-auth to 0.14.1 for their Vitest 5 peers. Couple cli-shared-helpers 0.2.7, containers-shared 0.23.1, and deploy-helpers 0.22.1 so retained remote-bindings has one compatible workers-utils type identity. Keeping deploy-helpers 0.21.0 fails its type check: createWorkerUploadForm expects the old Binding type with a different INHERIT_SYMBOL. This is a concrete build requirement introduced by this test migration; the earlier Container backport does not need this upgrade by itself. The remaining lockfile is regenerated by pnpm, rather than copying main's lockfile.
Stacked on #16373, above #16334 and runtime #16333. Miniflare 5.20261019.1-beta / Wrangler 4.151.3 remain supplied by #16333; this PR does not repeat or revert the runtime upgrade. No public sibling source or upstream dependency tests are restored. Main's C3 templates, Wrangler tests, and removed packages are excluded. No plugin changeset: the behavior change is internal test tooling and compatible helper peers, with no new user-facing plugin behavior.
Validation on Node.js 22.22.1 / pnpm 10.33.0: build (3 tasks), all retained suites (8 tasks, including 211 plugin tests, 28 remote-bindings tests, 277 asset-worker tests and 65 router-worker tests), and pnpm check (58 tasks) pass. Existing React SPA and Workflow playgrounds pass in dev (9 passed, 3 expected failures) and build/preview (11 passed, 1 expected skip). Offline frozen-lockfile install passes. Selected package-manager E2E coverage passes: npm/yarn (34 tests) and pnpm 10.33.0 (22 tests, 6 files). An initial pnpm attempt used Corepack's external-fixture default 11.28.5 and rejected ignored build scripts; rerunning with the repository-declared 10.33.0 resolved every fixture setup failure. Cross-platform CI remains required.
Note
This is a contribution from an AI agent: Codex, preparing maintainer-requested v1 backports.