Repository navigation
[vite-plugin] Preserve Worker response status text in v1 - #16493
Conversation
🦋 Changeset detectedLatest commit: 3994dcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@james-elicx (recorded author of #16453) and @petebacondarwin (verified human ant-core approver), could you please check this Vite plugin v1 backport and approve it if it looks good? V1 uses the same shared HTTP adapter for dev and preview. This independently upgrades its exact 0.8.1 pin to the published 1.0.0 release and retains the original custom/empty/omitted status-text regressions. Earlier #16480 supplies the retained Undici upgrade; those pins are preserved. Build, checks/types, retained tests/fixtures and the WebSocket dev/preview playground pass. |
|
Codeowners approval required for this PR:
|
|
✅ Approved — No issues found. The pull request pins The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed📋 Code Quality: ✅ LGTMThe dependency change is one line. It pins The new parameterized tests run the plugin's This review could not confirm that the 1.0.0 release still exports 📝 Documentation: ✅ LGTMThe changeset Reviewed commit: |
commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Backports #16453 to Vite plugin v1.
The shared HTTP adapter currently replaces Worker response status text with Node defaults in both dev and preview. Pin the published
@remix-run/node-fetch-server1.0.0 release, regenerate the lockfile with pnpm 10.33.0, and retain the original regression cases for custom, empty, and omitted status text. V1 previously pinned 0.8.1, so this is an independently useful remaining fix.Stacked on #16480; its earlier Undici/runtime versions are preserved. The unpublished October 23 runtime draft remains above the published-dependency fixes.
Validation:
pnpm build,pnpm check(including types),pnpm test:ci, and retained fixtures pass with Node 22.22.1 / pnpm 10.33.0. The HTTP tests exercise the plugin's actual request handler over a local socket. The WebSocket playground passes all 4 dev and 4 preview tests.Note
This is a contribution from an AI agent: Codex.