Repository navigation
[vite-plugin] Update v1 to the October 23 runtime - #16444
petebacondarwin merged 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 3eb00cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dependabot[bot] (recorded bot author of #16403) and @petebacondarwin (verified human ant-core approver), please check this Vite plugin v1 backport and approve it once it is ready and looks good. V1 uses the bundled workers-utils fallback compatibility date and Miniflare for dev/preview. This adapts the original to intended pinned npm dependencies: Miniflare This remains draft: the runtime/helper versions from pending release #16429 are unpublished (npm HTTP 404), so real pnpm lockfile regeneration and build/type/test validation must follow publication. Static checks pass; no runtime validation against the intended versions is claimed. |
b53c0eb to
0abad25
Compare
|
@dependabot[bot] (recorded bot author of #16437) and @edmundhung (verified human ant-core approver), please check this Vite plugin v1 backport and approve it once it is ready and looks good. V1 uses the bundled workers-utils fallback compatibility date and Miniflare in dev/preview. Pending release #16429 now combines #16403 and #16437 into the October 23 runtime. This existing supplying backport advances to intended Miniflare This remains draft: all six required runtime/helper releases return npm HTTP 404, and a real pnpm resolution attempt fails for the intended Miniflare version. Metadata checks pass; genuine lockfile regeneration and build/type/test validation must follow publication. Private workspace references and intentional public-source removals are preserved. |
|
@tannerlinsley (author of #16476) and @petebacondarwin (verified human ant-core approver), please check the public dependency portion of this Vite plugin v1 backport and approve it once it is ready and looks good. Parent #16480 supplies the independently useful retained remote-bindings Undici This stays draft: all six required runtime/helper versions still return npm HTTP 404 and genuine pnpm resolution fails for the intended Miniflare. Static metadata checks pass, but intended-dependency build/type/runtime validation requires publication and real lock regeneration. No removed public source or upstream regression tests are restored. Existing requests for #16403 and #16437 are not repeated. |
|
@Cherry (recorded author of #16485) and @petebacondarwin (verified human ant-core approver), could you please check this Vite plugin v1 backport and approve it if it looks good? Published workers-auth Build, all workspace checks/types, retained tests/fixtures, 39 tests in each of local dev/preview, the default-date API, and 3 credential-free package-manager E2E tests pass with the intended published dependencies. Ancestor #16407 still needs live Hyperdrive PostgreSQL/MySQL queries. |
|
@petebacondarwin (recorded author of #16490) and @edmundhung (verified human ant-core approver), could you please check this Vite plugin v1 backport and approve it if it looks good? This supplies the public Miniflare/helper portion of the Zod update through their actual published releases. Earlier #16502 separately upgrades the retained workers-shared validator. Its catalog/lock changes stay in that parent, and the single existing runtime changeset describes this dependency upgrade. Build, all workspace checks/types, retained tests/fixtures, 39 tests in each of local dev/preview, the default-date API, and 3 credential-free package-manager E2E tests pass with the intended published dependencies. Ancestor #16407 still needs live Hyperdrive PostgreSQL/MySQL queries. |
|
@workers-devprod (recorded author, ANT Bot release automation account of #16429) and @NuroDev (verified human ant-core approver), could you please check this Vite plugin v1 backport and approve it if it looks good? The mixed v2 release is the trigger for the compatible Miniflare Build, all workspace checks/types, retained tests/fixtures, 39 tests in each of local dev/preview, the default-date API, and 3 credential-free package-manager E2E tests pass with the intended published dependencies. Ancestor #16407 still needs live Hyperdrive PostgreSQL/MySQL queries. |
|
Codeowners approval required for this PR:
|
commit: |
|
💬 Approved with comments — The dependency pins are exact and consistent, and the private workspace references are kept. The only finding is an INFO note: fixtures and playgrounds still pin Wrangler below the plugin's new peer minimum. Findings: 1 info The decision is advisory: this comment never approves, blocks or requests changes on the pull request. 📋 Code Quality: 💬 1 infoThe pins are consistent. One INFO note: fixtures and playgrounds still pin Wrangler 4.151.0. Recommendation: 💬 Optional Nits
View full review🔄 Since last review: the WebSocket ownership change and its changeset are no longer part of this diff, so the earlier WARNING and the note about the out-of-date description are resolved. The note about the Wrangler pins still applies. What was checked
Wrangler pins below the new peer minimum
✅ All other checks passed🚀 Release: ✅ LGTMRisk: Low. There is a single plugin patch changeset, and the v1 prerelease metadata is preserved. The Wrangler pins in the fixtures are covered in the code quality section. 🔒 Security: ✅ LGTMThis pull request only bumps published packages to exact versions. The private workspace references are unchanged. 📖 AGENTS.md: ✅ LGTMPublic packages come from npm at exact versions, and private packages stay as ⚡ Performance: ✅ LGTMNo performance concerns. 📝 Documentation: ✅ LGTMThe runtime changeset describes the change users will see. Reviewed commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Consolidate the existing final backport diff before rebasing onto the current v1 stack. #16444
3eb00cd to
d127f1d
Compare
Stacked directly on #16540 (replacement for auto-merged #16538), with #16539 following this runtime upgrade.
Backports the useful runtime and fallback compatibility-date behavior from #16403 and #16437, using the now-merged mixed-v2 release #16429.
V1 exports
getLocalWorkerdCompatibilityDate(), fills missing dates from the bundled workers-utils default, and runs dev/preview through Miniflare. Pin the published Miniflare5.20261023.0-betain all three retained consumers, Wrangler4.153.0and its peer minimum, Workers types5.20261023.1, and the matching helpers. All five direct workers-utils consumers move together to actual release0.49.0; deploy-helpers0.24.0, containers-shared0.23.3, and workers-auth0.15.1keep the public helper graph compatible. These supersede the unpublished0.48.1/0.23.1intentions in this draft. Preserve every privateworkspace:*reference and the plugin's v1 release metadata.Regenerate the genuine lockfile with pnpm 10.33.0. Earlier backports supply the retained Undici 7.30.1 client (#16480), HTTP adapter (#16493), request cookie fix (#16501), retained Zod (#16502), export cleanup (#16503), and WebSocket ownership fix (#16504). Their upgrades stay in those parents exactly once. This PR's remaining diff contains only the runtime/helper/types pins, their real lock changes, and the existing single runtime changeset.
The released runtime/helper packages also supply the public dependency portions of #16476 (Undici) and #16490 (Zod). Published workers-auth
0.15.1supplies #16485's Windows keyring installation fix for retained remote-bindings authentication. There are no copied public-package source files, upstream dependency tests, installed-Wrangler CLI tests, or extra mapping-only PRs/changesets. The new V5-only opt-in Artifacts simulator from #16177 is included in Miniflare but requires no v1 feature restoration.Publication is no longer blocked: npm returned HTTP 200 for Miniflare, Wrangler and all four coupled helpers. The actual release manifests and published dependency graph were compared before installing; intended versions alone were not treated as coverage.
Validation: Node 22.22.1 / pnpm 10.33.0; genuine frozen install,
pnpm build,pnpm check(including types),pnpm test:ci,pnpm test:fixtures, relevant local dev/preview playgrounds and credential-free package-manager E2E checks pass. Runtime/default-date API and all exact pins/private workspace references are verified. Ancestor #16407 separately still awaits actual PostgreSQL/MySQL queries through the plugin's dev/preview paths; no live credentials are configured here.Note
This is a contribution from an AI agent: Codex, preparing maintainer-requested v1 backports.