Repository navigation
[vite-plugin] Update retained v1 HTTP clients to Undici 7.30.1 - #16480
Conversation
🦋 Changeset detectedLatest commit: f207fea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@tannerlinsley (author of #16476) and @petebacondarwin (verified human ant-core approver), please check this Vite plugin v1 backport and approve it if it looks good. The concrete retained change upgrades the Undici client bundled from Build, all 58 checks, retained unit suites and fixtures, three selected local package-manager E2E assertions, and the local bindings playground in dev and preview pass with Node |
|
Codeowners approval required for this PR:
|
|
✅ Approved — A clean dependency pin update with an accurate plugin changeset; no issues found. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed📋 Code Quality: ✅ LGTMThe 📝 Documentation: ✅ LGTMThe plugin patch changeset accurately describes what users will notice and what changed in the bundled dependency. Reviewed commit: |
commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Backport the independently useful retained portion of #16476. Vite plugin v1 bundles
remote-bindings, whosetryExpandToken()calls Undicifetch()for the preview-token exchange. Undici 7.29.1 can emit an unhandled stream error after a malformed response rejects, terminating the dev process. Update the shared Undici and matching types catalog pins to7.30.1, regenerate the pnpm lockfile, and add a plugin patch changeset for this bundled runtime dependency.Stacked on the built-in-module backport #16479, which follows existing Hyperdrive #16407. The independent remaining diff is three files: the two catalog pins, their real pnpm-generated lock changes, and the plugin changeset. Preserve all private
workspace:*references and exact public package pins. No public Miniflare source or upstream regression test is copied into this branch.This fixes the retained client's bundled Undici copy. Published Miniflare
5.20261019.2-betaand the published helpers still contain Undici7.29.1; this PR does not claim to update those bundled copies. Pending main release #16429 includes the upstream fix in Miniflare5.20261023.0-beta, Wrangler4.153.0and coupled helpers. Existing runtime draft #16444 will supply those exact dependency versions after this PR, once npm publication permits real lock regeneration and validation. No new release-only PR or duplicated public dependency changeset is needed.Validation uses Node
22.22.1and pnpm10.33.0, including the same pinned pnpm inside temporary package-manager projects.pnpm build, all 58pnpm checktasks, and all eight retainedpnpm test:citasks pass (including 211 plugin tests and 31 remote-bindings tests). The built plugin bundle contains the retained Undici7.30.1implementation. The local bindings playground passes all 10 tests in both dev and build/preview. Three selected local package-manager E2E tests also pass; no credentialed deployment tests were run.pnpm test:fixturespasses, including all 30 dev-registry tests, five test-harness Vitest tests and two Playwright tests.Note
This is a contribution from an AI agent: Codex, preparing maintainer-requested v1 backports.