Repository navigation
[vite-plugin] Update v1 development registry and runtime - #16539
Conversation
🦋 Changeset detectedLatest commit: 6dfb3dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
|
|
@petebacondarwin (original author) @dario-piotrowicz (human ant-core approver): please check this v1 backport coverage of #16494 and approve it if it looks good. For v1, the runtime resolver is consumed through published Miniflare 5.20261023.1-beta; retained fixtures use the canonical override and both fixture launchers use matching Wrangler. Private workspace references are preserved. Build/checks, retained tests and root fixtures, including 30 cross-tool registry tests, pass; relevant dev/preview playgrounds pass. Earlier runtime and helper versions are supplied by #16444. |
|
@workers-devprod (recorded author: ANT Bot release account) @dario-piotrowicz (human ant-core approver): please check this v1 backport coverage of #16500 and approve it if it looks good. For v1, this reuses the release's published Miniflare 5.20261023.1-beta, Wrangler 4.154.0 and coupled deploy-helpers 0.24.1. No separate release-mapping PR or duplicated dependency changeset is needed. Build/checks, retained tests and root fixtures, including 30 cross-tool registry tests, pass; relevant dev/preview playgrounds pass. Earlier runtime and helper versions are supplied by #16444. |
|
@dinasaur404 (original author) @edmundhung (human ant-core approver): please check this v1 backport coverage of #16499 and approve it if it looks good. For v1, this supplies the public Miniflare serialization portion via the released dependency; the next stacked backport enables the independently required flag in retained remote-proxy code. Public source/tests are not restored. Build/checks, retained tests and root fixtures, including 30 cross-tool registry tests, pass; relevant dev/preview playgrounds pass. Earlier runtime and helper versions are supplied by #16444. |
|
✅ Approved — Version bumps are consistent and the lockfile matches them. The fixture and launcher changes keep the registry paths isolated and test which path takes priority. No issues found. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed🚀 Release: ✅ LGTMRisk: low. Earlier tags and release branches are not in the data available here, so they were not checked. 🔒 Security: ✅ LGTMNo security concerns in the dependency bumps or the fixture changes. 📖 AGENTS.md: ✅ LGTMThe change follows the repository rules: private 📋 Code Quality: ✅ LGTM
⚡ Performance: ✅ LGTMNo performance concerns. 📝 Documentation: ✅ LGTMThe changeset explains the registry path change and Wrangler's different default. Reviewed commit: |
commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Consolidate the existing final backport diff before rebasing onto the current v1 stack. #16539
6dfb3dd to
dd7438d
Compare
Backports #16494 to Vite plugin v1, stacked on #16444, after #16540 (replacement for #16538) and #16504. Also supplies the compatible published Miniflare release from #16500; no separate release-mapping PR is necessary.
V1 calls Miniflare's registry resolver when creating its dev/preview runtimes and reading shortcut bindings. Upgrade all three direct Miniflare consumers from
5.20261023.0-betato published5.20261023.1-beta, with Wrangler4.154.0(dependency and peer minimum) and coupled deploy-helpers0.24.1. The retained dev-registry fixture and its shared process launcher also need Wrangler4.154.0to understand the canonical override. Preserve privateworkspace:*references and regenerate the real pnpm lockfile.Apply the original retained fixture/helper changes: use
CLOUDFLARE_DEV_REGISTRY_PATH, and verify Vite and Wrangler discovery despite conflicting legacy paths. The plugin's existinggetDefaultDevRegistryPath()calls already use the new resolver, so no duplicate implementation is needed. A minor plugin changeset explains the registry path migration and Wrangler's intentionally different default. No public Miniflare/Wrangler source or upstream tests are restored.This runtime also supplies the public serialization portion of #16499. Its independent retained remote-proxy compatibility flag is handled in the next backport.
Validation: Node 22.22.1 / pnpm 10.33.0; genuine lock regeneration and frozen install;
pnpm build,pnpm check,pnpm test:ci,pnpm test:fixtures, and relevant playgrounds in dev and built preview.Note
This is a contribution from an AI agent: Codex, under the authorized v1 backport automation.