Skip to content

[vite-plugin] Update v1 development registry and runtime - #16539

Merged
petebacondarwin merged 1 commit into
codex/vite-v1-backport-16403from
codex/vite-v1-backport-16494
Oct 28, 2026
Merged

petebacondarwin merged 1 commit into
codex/vite-v1-backport-16403from
codex/vite-v1-backport-16494

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Backports #16494 to Vite plugin v1, stacked on #16444, after #16540 (replacement for #16538) and #16504. Also supplies the compatible published Miniflare release from #16500; no separate release-mapping PR is necessary.

V1 calls Miniflare's registry resolver when creating its dev/preview runtimes and reading shortcut bindings. Upgrade all three direct Miniflare consumers from 5.20261023.0-beta to published 5.20261023.1-beta, with Wrangler 4.154.0 (dependency and peer minimum) and coupled deploy-helpers 0.24.1. The retained dev-registry fixture and its shared process launcher also need Wrangler 4.154.0 to understand the canonical override. Preserve private workspace:* references and regenerate the real pnpm lockfile.

Apply the original retained fixture/helper changes: use CLOUDFLARE_DEV_REGISTRY_PATH, and verify Vite and Wrangler discovery despite conflicting legacy paths. The plugin's existing getDefaultDevRegistryPath() calls already use the new resolver, so no duplicate implementation is needed. A minor plugin changeset explains the registry path migration and Wrangler's intentionally different default. No public Miniflare/Wrangler source or upstream tests are restored.

This runtime also supplies the public serialization portion of #16499. Its independent retained remote-proxy compatibility flag is handled in the next backport.

Validation: Node 22.22.1 / pnpm 10.33.0; genuine lock regeneration and frozen install; pnpm build, pnpm check, pnpm test:ci, pnpm test:fixtures, and relevant playgrounds in dev and built preview.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: the changeset records the dependency and registry migration for v1; this reuses the upstream feature documentation.

Note

This is a contribution from an AI agent: Codex, under the authorized v1 backport automation.


Devin Review

@changeset-bot

changeset-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6dfb3dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
workers-devprod requested review from a team and dario-piotrowicz and removed request for a team October 28, 2026 11:06
@workers-devprod

workers-devprod commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@petebacondarwin (original author) @dario-piotrowicz (human ant-core approver): please check this v1 backport coverage of #16494 and approve it if it looks good. For v1, the runtime resolver is consumed through published Miniflare 5.20261023.1-beta; retained fixtures use the canonical override and both fixture launchers use matching Wrangler. Private workspace references are preserved. Build/checks, retained tests and root fixtures, including 30 cross-tool registry tests, pass; relevant dev/preview playgrounds pass. Earlier runtime and helper versions are supplied by #16444.

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@workers-devprod (recorded author: ANT Bot release account) @dario-piotrowicz (human ant-core approver): please check this v1 backport coverage of #16500 and approve it if it looks good. For v1, this reuses the release's published Miniflare 5.20261023.1-beta, Wrangler 4.154.0 and coupled deploy-helpers 0.24.1. No separate release-mapping PR or duplicated dependency changeset is needed. Build/checks, retained tests and root fixtures, including 30 cross-tool registry tests, pass; relevant dev/preview playgrounds pass. Earlier runtime and helper versions are supplied by #16444.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@dinasaur404 (original author) @edmundhung (human ant-core approver): please check this v1 backport coverage of #16499 and approve it if it looks good. For v1, this supplies the public Miniflare serialization portion via the released dependency; the next stacked backport enables the independently required flag in retained remote-proxy code. Public source/tests are not restored. Build/checks, retained tests and root fixtures, including 30 cross-tool registry tests, pass; relevant dev/preview playgrounds pass. Earlier runtime and helper versions are supplied by #16444.

Base automatically changed from codex/vite-v1-backport-16519 to codex/vite-v1-backport-16403 October 28, 2026 11:08
@clanky-the-clanker

clanky-the-clanker Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Approved — Version bumps are consistent and the lockfile matches them. The fixture and launcher changes keep the registry paths isolated and test which path takes priority. No issues found.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Risk: low. Earlier tags and release branches are not in the data available here, so they were not checked.


🔒 Security: ✅ LGTM

No security concerns in the dependency bumps or the fixture changes.


📖 AGENTS.md: ✅ LGTM

The change follows the repository rules: private workspace:* references are kept, public packages are updated by bumping their versions, and a plugin changeset is included.


📋 Code Quality: ✅ LGTM

  • Versions: they match across all manifests and the lockfile.
  • Launcher (fixtures/shared/src/run-wrangler-long-lived.ts): it fills in CLOUDFLARE_DEV_REGISTRY_PATH only when it isn't already set, and it uses the same isolated directory as the legacy path.
  • Tests: they check that the new variable takes priority over conflicting legacy paths, and they remove the stubbed variables afterwards.

⚡ Performance: ✅ LGTM

No performance concerns.


📝 Documentation: ✅ LGTM

The changeset explains the registry path change and Wrangler's different default.


Reviewed commit: dd7438d4 — same changes as 5a5f4974, so this is that commit's review (no new review was run; line numbers are as of 5a5f4974)

@pkg-pr-new

pkg-pr-new Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16539

commit: dd7438d

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

Consolidate the existing final backport diff before rebasing onto the current v1 stack.

#16539
@petebacondarwin
petebacondarwin force-pushed the codex/vite-v1-backport-16494 branch from 6dfb3dd to dd7438d Compare October 28, 2026 11:42
@petebacondarwin
petebacondarwin merged commit 046db08 into vite-plugin-v1 Oct 28, 2026
21 of 38 checks passed
@petebacondarwin
petebacondarwin deleted the codex/vite-v1-backport-16494 branch October 28, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants