Repository navigation
[vite-plugin] Resolve Durable Object runtime imports in v1 - #16479
Conversation
🦋 Changeset detectedLatest commit: ecd5512 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@apeacock1991 (author of #16452) and @petebacondarwin (verified human ant-core approver), please check this Vite plugin v1 backport and approve it if it looks good. V1 has the same built-in-module omission. The remaining four-file diff preserves the original runtime externalization, module-resolution playground import/assertion, and plugin patch changeset. Published Miniflare Build, all 58 checks, retained unit suites/fixtures, three selected local package-manager E2E tests, and both module-resolution variants in dev and preview pass with Node |
|
Codeowners approval required for this PR:
|
|
✅ Approved — This is a minimal, correct backport that adds one built-in module entry, with playground coverage and a patch changeset. No issues were found. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed📋 Code Quality: ✅ LGTMAdding 📝 Documentation: ✅ LGTMThe changeset Reviewed commit: |
commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Backport #16452 so Vite plugin v1 can build Workers importing
retryable()fromcloudflare:durable-objects. V1 has the same built-in module list omission as main, causing Vite to resolve this runtime module as an npm package. Add it to the list and retain the original module-resolution playground assertion in both normal andnodejs_compatvariants.Stacked on the existing Hyperdrive backport #16407. The remaining diff is exactly the original four files: one built-in list entry, the playground import/assertion, and a plugin patch changeset. Published Miniflare
5.20261019.2-betaalready provides this runtime module; no dependency upgrade or removed public package source is needed. The separate unpublished October 23 runtime draft #16444 will follow the testable backports.Validation with Node
22.22.1and pnpm10.33.0:pnpm build, all 58pnpm checktasks, and all retainedpnpm test:cisuites pass (211 plugin tests and 31 remote-binding tests). Both module-resolution playground variants pass in dev and build/preview: 22 tests per mode.pnpm test:fixturesalso passes, including the retained dev-registry and test-harness integrations. Three selected local package-manager E2E assertions also pass with the pinned pnpm. No credentialed E2E tests were run. The initial sandboxed unit run could not open local sockets; rerunning with the required access passed.Note
This is a contribution from an AI agent: Codex, preparing maintainer-requested v1 backports.