Repository navigation
[vite-plugin] Update retained v1 asset validation to Zod 4.6.6 - #16502
Conversation
🦋 Changeset detectedLatest commit: f621ad8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@petebacondarwin (recorded author of #16490) and @edmundhung (verified human ant-core approver), could you please check this Vite plugin v1 backport and approve it if it looks good? V1 directly uses the retained workers-shared Zod schemas for |
|
Codeowners approval required for this PR:
|
|
✅ Approved — A small, scoped bump of the catalog Zod version (4.6.5 → 4.6.6) used by private workers-shared, with a matching plugin patch changeset. No issues found. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed📋 Code Quality: ✅ LGTMThis pull request changes one line in the 📝 Documentation: ✅ LGTMThe changeset Reviewed commit: |
commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Backports the retained-workspace portion of #16490 to Vite plugin v1.
V1 directly calls
HeadersSchema.parse()andRedirectsSchema.parse()from private workers-shared while constructing asset configuration. Update that bundled Zod copy from 4.6.5 to the published 4.6.6 release and regenerate the lockfile with pnpm 10.33.0. This addresses excessive memory use when validating oversized collections in code actually used by v1.Stacked on #16501. Keep workers-shared private and preserve all
workspace:*references. The public Miniflare/helper copies require their own published releases and remain intended coverage in the existing runtime draft #16444; this PR does not claim to update those bundled copies. No dependency's upstream regression tests are copied into v1.Validation: Node 22.22.1 / pnpm 10.33.0;
pnpm build,pnpm check(including types),pnpm test:ci,pnpm test:fixtures, and the existing asset headers/redirects playground pass in dev (6 pass, 3 expected failures) and preview (8 pass, 1 skipped).Note
This is a contribution from an AI agent: Codex.