Skip to content

Use Docker to build website instead of requiring local PHP - #158

Merged
clue merged 2 commits into
clue:mainfrom
clue-labs:docker
Oct 18, 2026
Merged

clue merged 2 commits into
clue:mainfrom
clue-labs:docker

Conversation

@clue

@clue clue commented Oct 18, 2026

Copy link
Copy Markdown
Owner

This changeset updates the build to use Docker instead of requiring a local PHP and Composer installation. make now builds the website from the same Dockerfile the Docker Compose setup from #147 already uses and exports only the generated site into build/, so what gets deployed is exactly what the container serves.

This also means CI no longer needs to set up PHP. The HTML diff job still builds the base branch with that revision's own make, which now uses the PHP version that comes with the Ubuntu 26.04 runner from #155.

The generated website is unchanged, and the integration and Playwright tests pass as before.

Builds on top of #147, #125, #155, #84, #115 and #68
Refs https://github.com/clue-engineering/miley/pull/86 (private)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The container build and workflow changes are consistent, with no unresolved findings.

No open issues 🎉

What changed in this PR

Moves website generation into Docker, reusing the container build for deployment without requiring local PHP or Composer.

Changes:

  • Exports the generated site into build/ through Docker.
  • Removes explicit PHP setup from CI and HTML-diff workflows.
  • Documents container-based development requirements.
File Description
README.md Documents Docker-based development setup.
Makefile Builds and exports the website through Docker.
Dockerfile Separates site generation, export, and serving stages.
.github/​workflows/​diff.yml Removes explicit PHP setup for HTML comparisons.
.github/​workflows/​ci.yml Removes PHP setup from the deployment workflow.

Review effort: Balanced

@clue
clue merged commit d91782f into clue:main Oct 18, 2026
2 checks passed
@clue
clue deleted the docker branch October 18, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants