Repository navigation
Use Docker to build website instead of requiring local PHP - #158
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The container build and workflow changes are consistent, with no unresolved findings.
No open issues 🎉
What changed in this PR
Moves website generation into Docker, reusing the container build for deployment without requiring local PHP or Composer.
Changes:
- Exports the generated site into
build/through Docker. - Removes explicit PHP setup from CI and HTML-diff workflows.
- Documents container-based development requirements.
| File | Description |
|---|---|
| README.md | Documents Docker-based development setup. |
| Makefile | Builds and exports the website through Docker. |
| Dockerfile | Separates site generation, export, and serving stages. |
| .github/workflows/diff.yml | Removes explicit PHP setup for HTML comparisons. |
| .github/workflows/ci.yml | Removes PHP setup from the deployment workflow. |
Review effort: Balanced
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the build to use Docker instead of requiring a local PHP and Composer installation.
makenow builds the website from the sameDockerfilethe Docker Compose setup from #147 already uses and exports only the generated site intobuild/, so what gets deployed is exactly what the container serves.This also means CI no longer needs to set up PHP. The HTML diff job still builds the base branch with that revision's own
make, which now uses the PHP version that comes with the Ubuntu 26.04 runner from #155.The generated website is unchanged, and the integration and Playwright tests pass as before.
Builds on top of #147, #125, #155, #84, #115 and #68
Refs https://github.com/clue-engineering/miley/pull/86 (private)