Repository navigation
Update Sculpin from 3.2.0 to 3.3.2 - #160
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The Twig and Symfony major-version upgrades warrant human confirmation of the reported output comparison and passing end-to-end tests.
No open issues 🎉
What changed in this PR
Updates the site’s Sculpin build dependencies to address security advisories and adopt Twig 3 and Symfony 6.4, with no intended changes to public pages.
Changes:
- Raises the Sculpin requirement to
^3.3.2and refreshes locked dependencies. - Replaces four conditional Twig loops with nested
ifblocks, preserving yearly counts and unique tags.
| File | Description |
|---|---|
www/talks.html.twig |
Migrates talk-count and tag loops to Twig 3 syntax. |
www/blog.html.twig |
Migrates post-count and tag loops to Twig 3 syntax. |
composer.lock |
Locks updated Sculpin and transitive dependencies. |
composer.json |
Raises the minimum supported Sculpin version. |
Review effort: Balanced
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates Sculpin from
3.2.0to3.3.2, which brings Twig 3 and Symfony 6.4:3.2.0->3.3.2v2.16.1->v3.30.0v4.4->v6.4v3.7.7->v4.1.6The other lock changes are smaller
psr/*,dflydev/*and polyfill packages that follow along. Twig 3 no longer supports conditions onforloops, so the four loops in the blog and talks templates now useifblocks instead.This also clears all 21
composer auditadvisories for our locked dependencies. Dependabot's security updates kept failing on these, because Sculpin 3.2 pins Twig 2 and Symfony 4.4.Nothing should change on the website. The generated pages are identical before and after this change, apart from the internal
.ignoreme.htmldummy that now consistently holds the most recent talk. The Playwright tests from #153 pass as well.Builds on top of #132 and #123