Conversation
Step 2 (th_exchange_token) discarded Meta's error object and returned a generic 'No access_token in exchange response', making real causes (invalid secret, expired code, permission scope, etc.) impossible to diagnose from the UI or logs. Step 1 already extracts Meta errors; this brings step 2 to parity and falls back to including the raw body. Refs #281
🔍 Cora AI Code ReviewReview powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Live diagnosis (Sep 23, #281 investigation): OAuth connect showed only
"Failed to get long-lived token: Threads API error: No access_token in
exchange response". Step 1 (code exchange) had already succeeded, so the
real rejection reason from Meta in step 2 (th_exchange_token) was thrown
away by this code path - the error body was never read.
Change
exchange_long_lived_tokennow extracts Meta'serrorobject (same asstep 1 does) and, when absent, includes the raw response body in the
error message. No behavior change on the success path.
Why it matters
Without the body, admins cannot distinguish: invalid/rotated app secret
vs expired code vs missing scope vs app-mode restrictions. With it, the
next OAuth failure is self-diagnosing.
Refs #281