Skip to content

fix(oauth): surface Meta error body in long-lived token exchange failure #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajianaz wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(oauth): surface Meta error body in long-lived token exchange failure #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions crates/titen-core/src/threads_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,20 @@ impl ThreadsClient {
.get("access_token")
.and_then(|v| v.as_str())
.ok_or_else(|| {
crate::error::TitenError::ThreadsApiError(
"No access_token in exchange response".to_string(),
)
// Surface Meta's error body instead of a generic message:
// without this, the actual failure reason (invalid secret,
// expired code, permission scope, etc.) is discarded and the
// UI only shows "No access_token in exchange response".
let meta_err = resp.get("error").map(|e| e.to_string()).unwrap_or_default();
if meta_err.is_empty() {
crate::error::TitenError::ThreadsApiError(format!(
"No access_token in exchange response (HTTP body: {resp})"
))
} else {
crate::error::TitenError::ThreadsApiError(format!(
"No access_token in exchange response: Meta error: {meta_err}"
))
}
})?
.to_string();

Expand Down
Loading