fix(deparser): keep the constraint name on EXCLUDE constraints - #331
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Constraint()only emittedCONSTRAINT <name>for a whitelist of contypes, andCONSTR_EXCLUSIONwas missing — so a named exclusion constraint silently lost its name on deparse:That's a real semantic loss: the constraint gets an auto-generated name, so
ALTER TABLE ... DROP CONSTRAINT one_pending_per_databaseand migration diffs break. Found while chasing the⚠️ AST round-trip diff detected!warning duringpgpm packagein constructive-db (metaschema_public.database_transfer).Fixture added to
__fixtures__/kitchen-sink/misc/issues.sql(inline named EXCLUDE +ALTER TABLE ADD CONSTRAINT ... EXCLUDE USING gist), regenerated vianpm run kitchen-sink. Full deparser suite passes (295 suites / 715 tests).Link to Devin session: https://app.devin.ai/sessions/5cfcc6690b574cdd96de080ee3b94b4e
Requested by: @pyramation