Update notification titles when a puzzle is renamed - #578
Closed
KingLizard1020 wants to merge 10 commits into
Closed
Update notification titles when a puzzle is renamed#578KingLizard1020 wants to merge 10 commits into
KingLizard1020 wants to merge 10 commits into
Conversation
mdirolf
requested changes
Sep 5, 2026
mdirolf
left a comment
mdirolf
left a comment
Member
There was a problem hiding this comment.
This looks great but can you find a way to clean up the commit history so you aren't deleting / recreating the puzzleUpdate test file multiple times? It just makes it harder to use git blame down the line. If you can't change it on this PR maybe a new PR with just the final changes to the two files?
Again - looks great! Thank you very much for contributing
Contributor
Author
|
Hi! Yes of course sorry about that, no clue what happened but was having some issues yesterday. |
Contributor
Author
|
Squashed this into a single commit as requested. New PR with the same two-file change and a clean history: #579 Closing this one so git blame is not polluted by the intermediate test-file delete/recreate commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you rename a puzzle, the puzzle document gets the new title but existing notifications still show the old one. They store a copy of the name as
pn, and nothing was writing that back on title edits.This updates those records in the puzzleUpdate trigger, same approach we already use when privateUntil changes. Added a test that renames one puzzle and checks only that puzzle’s notifications pick up the new title.
Fixes #577