Update notification titles when a puzzle is renamed - #579
Merged
mdirolf merged 1 commit intoSep 5, 2026
Merged
Conversation
When you rename a puzzle, existing notifications still show the old title stored as pn. Update those records in the puzzleUpdate trigger, matching the approach already used when privateUntil changes. Fixes crosshare-org#577
Member
|
Great - thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same change as #578, with the commit history squashed to a single commit as requested in review (the original PR had 10 commits that deleted/recreated the puzzleUpdate test file).
When you rename a puzzle, the puzzle document gets the new title but existing notifications still show the old one. They store a copy of the name as
pn, and nothing was writing that back on title edits.This updates those records in the puzzleUpdate trigger, same approach we already use when privateUntil changes. Added a test that renames one puzzle and checks only that puzzle’s notifications pick up the new title.
Fixes #577