Skip to content

secret-scan: PR-scoped Slack alerts with samples, per-repo internal-refs opt-out - #3

Merged
Abdelsalam-Abbas merged 1 commit into
mainfrom
abbas1/eng-552-secret-scan-notifications
Aug 3, 2026
Merged

secret-scan: PR-scoped Slack alerts with samples, per-repo internal-refs opt-out#3
Abdelsalam-Abbas merged 1 commit into
mainfrom
abbas1/eng-552-secret-scan-notifications

Conversation

@Abdelsalam-Abbas

Copy link
Copy Markdown
Collaborator

Manual sync of the upstream secret-scan changes (Astera-org/github-workflows#5). See that PR for full rationale.

  • Slack alerts on PRs now fire only for findings introduced by the PR's own commits; historical findings stay in the step summary and the informational check run instead of re-posting on every push.
  • Slack message includes the PR link, new-vs-total counts, and up to 5 sample rows (rule, file, line).
  • New per-repo opt-out for the internal-refs job: set the repo Actions variable SECRET_SCAN_SKIP_INTERNAL_REFS=true (intended for dynamic-pdb and similar repos that legitimately reference internal infra).

@Abdelsalam-Abbas
Abdelsalam-Abbas merged commit b03f493 into main Aug 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant