perf: the window package drops the unused Windows Runtime projection - R5/8b by donislawdev · Pull Request #138 · donislawdev/ChronoMock

donislawdev · 2026-10-21T14:47:59Z

Summary

The window package no longer carries the Windows Runtime projection it never used. Unpacked 169.6 to 146.6 MB (-23.0 MB, -13.6%), zipped 70.8 to 64.8 MB, 273 to 271 files.

The 10.0.17763 in the window's TFM pins the support floor (Windows 10 1809 / Server 2019). Any TFM version from 10.0 up also makes the SDK add the projection as a framework reference, and a self-contained publish then ships Microsoft.Windows.SDK.NET.dll (23.6 MB) and WinRT.Runtime.dll (0.5 MB). Nothing here uses it:

no GUI source names a WinRT Windows.* namespace, WinRT or ApiInformation
of the 225 managed assemblies in the published package, none but the projection itself references either assembly (wpfui 4.3.0 ships only net10.0-windows7.0 and references neither)
the window never loads them (startup hook, assemblies loaded by the first idle)

IncludeWindowsSDKRefFrameworkReferences=false in gui/Directory.Build.props keeps the projection out of both GUI projects while the TFM, and so the floor, stays.

Why this switch and not a TFM without a version

The documented route, net10.0-windows, means TargetPlatformVersion 7.0. The floor in the assembly then drops to Windows7.0, a higher SupportedOSPlatformVersion beside it is refused (NETSDK1135), and both lock files change their framework key. Measured: it builds without a warning, but it gives the floor up. The switch keeps the floor and the lock files as they are. It is the SDK's own property (Microsoft.NET.Windows.targets sets it to true only when a project leaves it empty) but it has no page on learn.microsoft.com, so the effect is checked where it ships (below).

Also

packaging/build-dist.ps1 stops if either projection file is in the publish, ahead of the register check, which would otherwise ask for the projection to be declared. The ReadyToRun check keeps its three assemblies and loses the two projection rows, and PublishReadyToRunExclude leaves the project.
packaging/components.json, THIRD-PARTY-NOTICES.md and the component-list test drop the projection. It was the one component in the package without an SPDX licence (LicenseRef-Microsoft-Windows-SDK).
CHANGELOG, Changed.

Verification

Published layout before and after, as build-dist.ps1 publishes it: the two projection files go, and three files change - ChronoMock.deps.json (loses the runtime pack entry), ChronoMock.dll and its pdb. All 2417 methods of ChronoMock.dll have the same IL, the metadata heaps the same sizes and the embedded resources the same bytes. The MVID differs because the compiler hashes the reference set into it. TargetPlatform and SupportedOSPlatform stay Windows10.0.17763.0.
A publish with CI=true (locked restore, ReadyToRun) succeeds and is byte for byte the same as the local one. Locked restores of both GUI projects pass, also with the restoring machine's identifier set to linux-x64 as on the dependency-submission runner. No lock file changes.
The new checks in build-dist.ps1, taken from the file and run on real publishes: pass on the new layout, stop on the old one (naming the projection) and on an IL-only build (ChronoMock.dll not compiled ahead). The register check stops on the new layout with the old register (declared, not bundled) and on the old layout with the new register (bundled, not declared).
Start, A/B alternating, 12 runs each: first frame median 784.6 ms before and 788.2 ms after, inside the run-to-run spread (767 to 825 ms), 1294 methods compiled by the JIT and the same 57 assemblies loaded in both.
State sheet render: 301 files, 118 images, byte for byte the same.
GUI test classes that build the window or read Directory.Build.props: 79 tests, green. The components, hygiene, names and msi guards and the component-list tests, green. clippy, clippy-pin, format-cs, metrics-pin, lint-ps (185 files). Mutation registry anchors: 1154 entries, 0 off.
No new mutation entry: the new check lives in the packaging script, which no test runner executes. It was reversed by hand on real publishes instead, as above.

Not measured

A restore still downloads the projection pack into the NuGet cache (downloadDependencies), as it does the ASP.NET Core runtime pack. Neither ships.
The installer's size is not compared here.

Also in this pull request (2026-10-26)

main and three Dependabot updates. One merge commit (39d9a81) brings main (#137, which this branch was stacked on, and the actions bump of #141) and the Dependabot branches of #117 (serde_json 1.0.154, toml 1.1.8, winresource 0.1.34), #139 (Microsoft.NET.Test.Sdk 18.11.0 in the protocol tests) and #140 (semgrep 1.181.0). Their commits come in unchanged, so those pull requests count as merged with this one.

The register follows two new versions (74717da). Each stopped a check on the open pull requests:

serde_json 1.0.154 failed the component guard on chore(deps): Bump the cargo-minor-and-patch group across 1 directory with 3 updates #117 (register 1.0.151, lockfile 1.0.154). Its dependencies did not change.
The runners install .NET SDK 10.0.403 since 2026-10-26, which publishes the window with the 10.0.14 runtime packs (the .NET security release of 2026-10-25), and build-dist.ps1 stopped the installer job on chore(deps): Bump the cargo-minor-and-patch group across 1 directory with 3 updates #117, chore(deps): Bump the nuget-minor-and-patch group with 1 update #139 and chore(ci): Bump semgrep from 1.180.0 to 1.181.0 in /.github/semgrep #140 (declared 10.0.13, bundled 10.0.14).

packaging/components.json, THIRD-PARTY-NOTICES.md and the unreleased CHANGELOG line about the bundled runtime name the new versions. A local build-dist.ps1 on SDK 10.0.403 passes the register check (27 components, 64.9 MB zip), and the component guards pass (components 13, --bins component 3).

The red CI on e8f5b9d (b2e4758). AnnounceTests.The_calculator_reads_its_answer_when_a_step_moves_it failed with "nothing was announced" after 17.7 s, where it takes 3.3 s on a desktop run alone and cold. NextAsync checked its deadline before it read the queue, so an announcement made just before the UI thread was held past the deadline was never read. It now reads the queue once more after the deadline, and a failure names how long it waited and what it passed over. The deadline goes from 5 s to 20 s, as it bounds only a failure.

A probe that holds the UI thread for the deadline and a second from the moment the announcement is made: the old helper fails it with "nothing was announced", the new one reads it, and the new one without the last read fails it at the 20 s deadline as well. The probe is not kept, it would add over 20 s to every run.
Not reproduced on a desktop: 4 runs of the class under 48 busy processes on 16 cores (2.5 to 3.4 s for this test) and 3 cold runs of the test alone (3.3 s). The GUI tests run one at a time (ParallelMode.None), so no other test shares the UI thread while it waits. What held the runner for about 12.7 s before the wait is not known, the log gives only the test's total time.
The other deadline loops of the GUI tests were read for the same shape. One had it: FilledScreenSweepTests.AnsweredAsync returned false at the deadline without a last look, so an answer that landed during a hold counted as none (8bddecc). The same probe, timed to the answer, fails the old helper and passes the new one. Its deadline stays at 5 s, and FilledScreenSweepTests is 4 of 4.
AnnounceTests 8 of 8 and HistoryErrorTests 2 of 2, format-cs, metrics-pin, clippy, clippy-pin, lint-ps, deny, the hygiene, names, components and network guards, and the mutation anchors (1154 entries, 0 off).

Not measured here: the semgrep bump is measured by this pull request's Semgrep job against the tree, as 1.179.0 and 1.180.0 were. The run against the release workflows before 3b94c4e, which must still report six, is still owed.

Stacking

Branched from perf/r5-8-cold-start (#137), merged since. With main merged in, this PR's diff is the R5/8b commit, the merge above and the three fixes.

🤖 Generated with Claude Code

…- R5/8b The 10.0.17763 in the window's TFM pins the support floor, and any TFM version from 10.0 up also makes the SDK add the Windows Runtime projection (Microsoft.Windows.SDK.NET.dll, 23.6 MB, and WinRT.Runtime.dll, 0.5 MB). No code here uses it, and of the 225 managed assemblies in the package none but the projection itself referenced it. IncludeWindowsSDKRefFrameworkReferences=false in gui/Directory.Build.props keeps it out while the TFM, and so the floor, stays. Measured on the published layout: 169.6 to 146.6 MB unpacked, 70.8 to 64.8 MB zipped, every method of ChronoMock.dll with the same IL and the same resources, SupportedOSPlatform still Windows10.0.17763.0, lock files unchanged, start unchanged (first frame median 784.6 against 788.2 ms, same JIT count, same assemblies loaded), state sheet render 301 files byte for byte. The switch has no page on learn.microsoft.com, so build-dist.ps1 checks the effect on the published files and stops if either file comes back, ahead of the register check that would otherwise ask for it to be declared. The register, the notices and the component-list test drop the projection, which was the one component without an SPDX licence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-21T14:57:31Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Advanced
Run ID: de5756c8-adbe-4092-9f48-75e1fa73ef9b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 90918d81-0635-4229-9d1d-ad7aee8bd961

📥 Commits

Reviewing files that changed from the base of the PR and between 7395f72 and e8f5b9d.

📒 Files selected for processing: 20

CHANGELOG.md
THIRD-PARTY-NOTICES.md
crates/cli/src/cli.rs
gui/ChronoMock.App.Tests/DeferredViewTests.cs
gui/ChronoMock.App.Tests/FilledScreenSweepTests.cs
gui/ChronoMock.App/App.xaml
gui/ChronoMock.App/ChronoMock.App.csproj
gui/ChronoMock.App/Controls/DeferredView.cs
gui/ChronoMock.App/MainWindow.xaml
gui/ChronoMock.App/Themes/Parts.xaml
gui/ChronoMock.App/Views/AuditSectionView.xaml
gui/ChronoMock.App/Views/CalculatorView.xaml
gui/ChronoMock.App/Views/ComponentCatalogue.xaml
gui/ChronoMock.App/Views/ResultPhaseView.xaml
gui/ChronoMock.App/Views/SessionPhaseView.xaml
gui/ChronoMock.App/Views/SetupPhaseView.xaml
gui/Directory.Build.props
packaging/build-dist.ps1
packaging/components.json
tests/mutation/entries.json

💤 Files with no reviewable changes: 1

packaging/components.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details

⚠️ CI failures not shown inline: 5

GitHub Actions: CI / 0_Gates.txt: perf: the window package drops the unused Windows Runtime projection - R5/8b

Conclusion: failure

View job details

##[group]Run $PSNativeCommandUseErrorActionPreference = $false
 �[36;1m$PSNativeCommandUseErrorActionPreference = $false�[0m
 �[36;1m$out = dotnet build gui/ChronoMock.slnx --no-incremental -p:ChronoMetricsConfig=D:\a\ChronoMock\ChronoMock/.github/metrics-tight/CodeMetricsConfig.txt -p:TreatWarningsAsErrors=false 2>&1 | Out-String�[0m
 �[36;1mif ($LASTEXITCODE -ne 0) {�[0m
 �[36;1m  Write-Host $out�[0m
 �[36;1m  Write-Host "::error::The tightened build did not compile, so the ceilings could not be measured."�[0m
 �[36;1m  exit 1�[0m
 �[36;1m}�[0m
 �[36;1m$reached = [regex]::Matches($out, 'warning (CA150[26])') | ForEach-Object { $_.Groups[1].Value } | Sort-Object -Unique�[0m
 �[36;1mforeach ($rule in 'CA1502', 'CA1506') {�[0m
 �[36;1m  if ($reached -notcontains $rule) {�[0m
 �[36;1m    Write-Host "::error::$rule in gui/CodeMetricsConfig.txt has room in it: nothing reaches it one below. Lower it to the real maximum, and .github/metrics-tight/CodeMetricsConfig.txt with it."�[0m
...
 ##[group]Run $PSNativeCommandUseErrorActionPreference = $false
 �[36;1m$PSNativeCommandUseErrorActionPreference = $false�[0m
 �[36;1m$lints = @(Get-Content .github/clippy-tight/clippy.toml | ForEach-Object { if ($_ -match '^\s*([a-z-]+)-threshold\s*=') { $Matches[1] -replace '-', '_' } })�[0m
 �[36;1mif ($lints.Count -eq 0) {�[0m
 �[36;1m  Write-Host "::error::No threshold was read from .github/clippy-tight/clippy.toml, so there is nothing to measure."�[0m
...
 �[36;1m$code = $LASTEXITCODE�[0m
 �[36;1m$messages = @($lines | Where-Object { $_.StartsWith('{') } | ForEach-Object { $_ | ConvertFrom-Json } | Where-Object { $_.reason -eq 'compiler-message' } | ForEach-Object { $_.message })�[0m
 �[36;1mif ($code -ne 0) {�[0m
 �[36;1m  $lines | Where-Object { -not $_.StartsWith('{') } | ForEach-Object { Write-Host $_ }�[0m
 �[36;1m  $messages | Where-Object { $_.level -eq 'error' } | ForEach-Object { Write-Host $_.rendered }�[0m
 �[36;1m  Write-Host "::error::The tightened clippy run did not c...

GitHub Actions: CI / Gates: perf: the window package drops the unused Windows Runtime projection - R5/8b

Conclusion: failure

View job details

##[group]Run $PSNativeCommandUseErrorActionPreference = $false
 �[36;1m$PSNativeCommandUseErrorActionPreference = $false�[0m
 �[36;1m$out = dotnet build gui/ChronoMock.slnx --no-incremental -p:ChronoMetricsConfig=D:\a\ChronoMock\ChronoMock/.github/metrics-tight/CodeMetricsConfig.txt -p:TreatWarningsAsErrors=false 2>&1 | Out-String�[0m
 �[36;1mif ($LASTEXITCODE -ne 0) {�[0m
 �[36;1m  Write-Host $out�[0m
 �[36;1m  Write-Host "::error::The tightened build did not compile, so the ceilings could not be measured."�[0m
 �[36;1m  exit 1�[0m
 �[36;1m}�[0m
 �[36;1m$reached = [regex]::Matches($out, 'warning (CA150[26])') | ForEach-Object { $_.Groups[1].Value } | Sort-Object -Unique�[0m
 �[36;1mforeach ($rule in 'CA1502', 'CA1506') {�[0m
 �[36;1m  if ($reached -notcontains $rule) {�[0m
 �[36;1m    Write-Host "::error::$rule in gui/CodeMetricsConfig.txt has room in it: nothing reaches it one below. Lower it to the real maximum, and .github/metrics-tight/CodeMetricsConfig.txt with it."�[0m

GitHub Actions: CI / Gates: perf: the window package drops the unused Windows Runtime projection - R5/8b

Conclusion: failure

View job details

##[group]Run $PSNativeCommandUseErrorActionPreference = $false
 �[36;1m$PSNativeCommandUseErrorActionPreference = $false�[0m
 �[36;1m$lints = @(Get-Content .github/clippy-tight/clippy.toml | ForEach-Object { if ($_ -match '^\s*([a-z-]+)-threshold\s*=') { $Matches[1] -replace '-', '_' } })�[0m
 �[36;1mif ($lints.Count -eq 0) {�[0m
 �[36;1m  Write-Host "::error::No threshold was read from .github/clippy-tight/clippy.toml, so there is nothing to measure."�[0m
...
 �[36;1m$code = $LASTEXITCODE�[0m
 �[36;1m$messages = @($lines | Where-Object { $_.StartsWith('{') } | ForEach-Object { $_ | ConvertFrom-Json } | Where-Object { $_.reason -eq 'compiler-message' } | ForEach-Object { $_.message })�[0m
 �[36;1mif ($code -ne 0) {�[0m
 �[36;1m  $lines | Where-Object { -not $_.StartsWith('{') } | ForEach-Object { Write-Host $_ }�[0m
 �[36;1m  $messages | Where-Object { $_.level -eq 'error' } | ForEach-Object { Write-Host $_.rendered }�[0m
 �[36;1m  Write-Host "::error::The tightened clippy run did not compile, so the ceilings could not be measured."�[0m
 �[36;1m  exit 1�[0m
 �[36;1m}�[0m
 �[36;1m$reached = @($messages | ForEach-Object { $_.code.code } | Where-Object { $_ } | Sort-Object -Unique)�[0m
 �[36;1m$slack = @($lints | Where-Object { $reached -notcontains "clippy::$_" })�[0m
 �[36;1mforeach ($lint in $slack) {�[0m
 �[36;1m  Write-Host "::error::The $lint ceiling in clippy.toml has room in it: nothing reaches it one below. Lower it to the real maximum, and .github/clippy-tight/clippy.toml with it."�[0m

GitHub Actions: CI / Gates: perf: the window package drops the unused Windows Runtime projection - R5/8b

Conclusion: failure

View job details

. ok
 test cdp::session::tests::an_injection_that_runs_out_of_time_takes_its_hook_back_and_queues_the_release ... ok
 test cdp::shim_exec::a_repeating_timer_keeps_its_cadence_and_takes_a_new_rate_from_its_next_tick ... ok
 test cdp::shim_exec::a_frozen_wall_stands_while_the_duration_axis_runs ... ok
 test cdp::shim_exec::a_timer_keeps_its_delay_when_only_the_wall_runs_fast ... ok
 test cdp::shim_exec::a_scheduled_rate_change_takes_effect_at_its_instant ... ok
 test cdp::shim_exec::a_timer_the_four_ms_floor_holds_back_is_noted ... ok
 test cdp::shim_exec::the_audit_notes_a_hidden_page_and_a_zone_it_did_not_read ... ok
 test cdp::shim_exec::a_second_install_a_foreign_marker_and_a_running_page_are_told_apart ... ok
 test cdp::shim_exec::the_engines_own_stamps_and_animations_are_noticed_and_handed_back_as_they_are ... ok
 test cdp::shim_exec::the_clock_is_closed_over_and_its_marker_cannot_be_moved ... ok
 test cdp::shim_exec::the_session_moves_counts_and_lets_go_of_the_page ... ok
 test cdp::tests::a_bad_ws_url_from_the_target_cannot_forge_a_line ... ok
 test cdp::tests::a_full_queue_keeps_its_target_events ... ok
 test cdp::tests::a_hidden_character_at_the_cap_counts_once ... ok
 test cdp::tests::a_lone_surrogate_is_refused_by_the_parser_and_repaired_by_us ... ok
 test cdp::shim_exec::time_origin_plus_now_is_the_session_clock ... ok
 chrono core: skipped a CDP message that was not JSON
 test cdp::shim_exec::the_moves_the_audit_and_the_release_reach_the_frames_of_the_page ... ok
 test cdp::tests::a_proper_pair_and_an_escaped_backslash_are_left_alone ... ok
 test cdp::tests::a_peer_answering_a_byte_at_a_time_cannot_keep_a_request_past_its_deadline ... ok
 test cdp::tests::a_message_that_is_not_json_is_skipped_and_the_next_one_still_arrives ... ok
 test cdp::tests::a_target_error_cannot_forge_a_report_line ... ok
 test cdp::tests::a_queue_of_target_events_reports_only_the_drop_that_happened ... ok
 test cdp::tests::a_ws_url_on_another_port_is_refused ... ok
 test cdp::...

GitHub Actions: CI / Gates: perf: the window package drops the unused Windows Runtime projection - R5/8b

Conclusion: failure

View job details

##[group]Run dotnet test --solution gui/ChronoMock.slnx --filter-not-trait "Category=Integration"
 �[36;1mdotnet test --solution gui/ChronoMock.slnx --filter-not-trait "Category=Integration"�[0m
 shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
 env:
   DOTNET_ROOT: C:\Program Files\dotnet
   CACHE_ON_FAILURE: false
   CARGO_INCREMENTAL: 0
 ##[endgroup]
 Running tests from D:\a\ChronoMock\ChronoMock\gui\ChronoMock.Protocol.Tests\bin\Debug\net10.0\ChronoMock.Protocol.Tests.dll (net10.0|x64)
 Running tests from D:\a\ChronoMock\ChronoMock\gui\ChronoMock.App.Tests\bin\Debug\net10.0-windows10.0.17763.0\ChronoMock.App.Tests.dll (net10.0|x64)
 �[mD:\a\ChronoMock\ChronoMock\gui\ChronoMock.Protocol.Tests\bin\Debug\net10.0\ChronoMock.Protocol.Tests.dll (net10.0|x64) �[32mpassed�[m �[90m(4s 365ms)�[m
 �[31mfailed�[m ChronoMock.App.Tests.AnnounceTests.The_calculator_reads_its_answer_when_a_step_moves_it �[90m(17s 728ms)�[m
   from D:\a\ChronoMock\ChronoMock\gui\ChronoMock.App.Tests\bin\Debug\net10.0-windows10.0.17763.0\ChronoMock.App.Tests.dll (net10.0|x64)
 �[31m  nothing was announced
 �[m�[90m    at ChronoMock.App.Tests.AnnounceTests.NextAsync(Heard heard, Func`2 wanted) in D:\a\ChronoMock\ChronoMock\gui\ChronoMock.App.Tests\AnnounceTests.cs:250�[90m
     at ChronoMock.App.Tests.AnnounceTests.<>c.<<The_calculator_reads_its_answer_when_a_step_moves_it>b__7_0>d.MoveNext() in D:\a\ChronoMock\ChronoMock\gui\ChronoMock.App.Tests\AnnounceTests.cs:148�[90m
     --- End of stack trace from previous location ---
 �[90m    --- End of stack trace from previous location ---
 �[m�[mD:\a\ChronoMock\ChronoMock\gui\ChronoMock.App.Tests\bin\Debug\net10.0-windows10.0.17763.0\ChronoMock.App.Tests.dll (net10.0|x64) �[31mfailed with 1 error(s)�[m �[90m(3m 20s 958ms)�[m
 Exit code: 2
 �[31mTest run summary: Failed!
   �[mD:\a\ChronoMock\ChronoMock\gui\ChronoMock.Protocol.Tests\bin\Debug\net10.0\ChronoMock.Protocol.Tests.dll (net10.0|x64) �[32mpassed�[m �[90m(4s 365ms)�[m
   �[m...

🧰 Additional context used

📚 Code guidelines: 2

SECURITY.md — configured
CONTRIBUTING.md — configured

📓 Path-based instructions: 19

Packaging and release configuration of a desktop app.