Make groom publisher fixture date-relative instead of hard-coded - #1262
Open
qapdex-maker wants to merge 1 commit into
Open
qapdex-maker wants to merge 1 commit into
qapdex-maker wants to merge 1 commit into
Conversation
The resolved-dispatched fixture pinned correlation_date to 2026-09-16. The groom publisher expires resolved outbox rows older than 14 days using Date.now(), so the fixture silently started failing once real time passed that date (observed red on 2026-10-02, test_groom_publisher_preserves_ resolved_dispatched_rows). Default the correlation to yesterday so the row stays inside the retention window; the expiry test still pins 2000-01-01 explicitly.
Contributor
|
Note This PR is from a fork and modifies infrastructure files ( Changes to infrastructure typically need to be submitted from a branch in Please consider recreating this PR from an upstream branch. If you don't have push access to |
3 of 6 tasks
Collaborator
|
Thanks a bunch for catching and fixing this, @qapdex-maker. I preserved your original commit and credit in the trusted follow-up PR #1264. I also added a small follow-up so the status-parser test checks the new date-relative correlation instead of the old fixed value. (Copilot, commenting on Abhitej's behalf.) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
token-failoverjob ofevaluation-workflow-testswent red on2026-10-02 (run 37046657914) in
test_groom_publisher_preserves_resolved_dispatched_rows.Cause
devops-health-groom.mddrops a resolved outbox row once it is older than14 days, using
Date.now():The fixture in
run_groom_publisher_without_rowspinnedcorrelation_datetothe literal
2026-09-16. Once real time passed that date the row was treatedas expired, silently omitted from the rendered dashboard, and the assertion
assertIn("🔄 Dispatched", ...)failed with an empty island table.This is a time-bomb fixture, not a product bug. It will fail again for anyone
running the suite later than 14 days after the pinned date.
Fix
Default
correlation_dateto yesterday, so the row is always inside theretention window, and derive
first_seenand the table's First Seen columnfrom the same value. The expiry test still passes
2000-01-01explicitly, sothe expiry path stays covered.
Verification
Same worktree, before vs after the patch:
FAILED (failures=1, errors=23)FAILED (errors=23)The 23 errors are all
FileNotFoundError: 'pwsh'from the local machine havingno PowerShell, unrelated to this change. The single failure this fixes is gone.