Make groom publisher fixture date-relative - #1264
Merged
Merged
Conversation
The resolved-dispatched fixture pinned correlation_date to 2026-09-16. The groom publisher expires resolved outbox rows older than 14 days using Date.now(), so the fixture silently started failing once real time passed that date (observed red on 2026-10-02, test_groom_publisher_preserves_ resolved_dispatched_rows). Default the correlation to yesterday so the row stays inside the retention window; the expiry test still pins 2000-01-01 explicitly.
Assert against the same date-relative correlation used by the fixture so the status parser test continues to detect a retained resolved row. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: aae5ab40-5238-4540-b192-7cdf544a656d
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fixture update preserves explicit expiry coverage while eliminating the time-dependent failure.
Review effort: Balanced
Findings: None
What changed in this PR
Makes the groom publisher fixture date-relative so retention tests remain valid over time.
Changes:
- Defaults fixture correlations to yesterday.
- Keeps
first_seen, table dates, and correlation IDs aligned. - Updates the parser test to assert the generated correlation.
| File | Description |
|---|---|
eng/evaluation/test_token_failover.py |
Replaces stale fixed fixture dates with date-relative values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AbhitejJohn
enabled auto-merge
October 5, 2026 18:03
Contributor
|
✅ Evaluation passed for |
y87feng
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This carries forward @qapdex-maker's fix from #1262 with the original contributor-authored commit preserved. The groom publisher fixture now defaults to yesterday instead of a fixed date, so the resolved-dispatched test remains inside the 14-day retention window as time advances.
The related status-parser test now passes that date explicitly and checks the exact generated correlation. This keeps the assertion effective instead of checking a stale hard-coded identifier.
Related issue
Supersedes #1262 through a trusted branch. Full credit for the original fix goes to @qapdex-maker.
Validation
python -m unittest eng.evaluation.test_token_failover.TokenFailoverTests.test_groom_status_parser_ignores_result_text— passed (1 test).python eng\evaluation\test_token_failover.py— passed (50 tests, 3 skipped).git diff --check— passed.Checklist
eng/known-domains.txtfor any new external domains referenced by skill content.