Repository navigation
fix: remove obsolete Valid generation workflow - #1524
Merged
Merged
Conversation
joaodinissf
commented
Sep 7, 2026
| @@ -10,9 +10,6 @@ | |||
| /com.avaloq.tools.ddk.check.*/** @dsldevkit/sca | |||
Collaborator
Author
There was a problem hiding this comment.
@rubenporras I think this file is basically useless now--I'd suggest we either fix this (I don't have permissions) or delete the file, as you prefer.
Member
There was a problem hiding this comment.
Yes, I think we should remove it
joaodinissf
enabled auto-merge (rebase)
September 7, 2026 10:56
rubenporras
approved these changes
Sep 7, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1523 removes the Valid language bundles, but the aggregate generation workflow still invokes Valid and its dedicated workflow references the deleted grammar and metamodels. Remove that invocation and
GenerateValid.mwe2, together with the stale README module row and CODEOWNERS entry.Follow-up to merged PR #1523, based on updated
master. The diff contains only the four cleanup files.Shared validation support remains unchanged, including
ValidCompositeEValidator, which Check DSL still extends.Validation: repository reference scan confirms no remaining removed-bundle references or Valid workflow invocation; shared Check validator inheritance verified;
git diff --checkand the repository line-ending check passed. Maven and Eclipse/MWE2 regeneration were not rerun; the workflow project is outside the Maven reactor.