Skip to content

fix: remove obsolete Valid generation workflow #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaodinissf merged 1 commit into from
Sep 7, 2026
Merged

fix: remove obsolete Valid generation workflow #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
/com.avaloq.tools.ddk.check.*/** @dsldevkit/sca

@joaodinissf joaodinissf Sep 7, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubenporras I think this file is basically useless now--I'd suggest we either fix this (I don't have permissions) or delete the file, as you prefer.

@joaodinissf joaodinissf Sep 7, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@rubenporras rubenporras Sep 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should remove it

/com.avaloq.tools.ddk.checkcfg.*/** @dsldevkit/sca

# Valid DSL (obsolete SCA)
/com.avaloq.tools.ddk.xtext.valid*/** @dsldevkit/sca

# Generating workflow
/com.avaloq.tools.ddk.workflow/** @dsldevkit/codeowners

Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ You can find more detailed documentation and examples at [ddk.tools.avaloq.com](
| com.avaloq.tools.ddk.xtext.checkcfg.\* | Check Configuration DSL |
| com.avaloq.tools.ddk.xtext.scope.\* | Scope DSL |
| com.avaloq.tools.ddk.xtext.export.\* | Export DSL |
| com.avaloq.tools.ddk.xtext.valid.\* | obsolete and is replaced by Check DSL |
| com.avaloq.tools.ddk.typesystem | Basics for building a typesystem for a DSL |
| com.avaloq.tools.ddk.test.\* | Support for writing tests for DSLs |
| com.avaloq.tools.ddk.xtextspy.\* | View to support debugging a DSL |
Expand Down
1 change: 0 additions & 1 deletion com.avaloq.tools.ddk.workflow/src/com/avaloq/tools/ddk/workflow/Ddk.mwe2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ Workflow {
component = @ Scope {}
component = @ Check {}
component = @ CheckCfg {}
component = @ Valid {}
component = @ TypeModel {}
component = @ ModelInference {}
}
165 changes: 0 additions & 165 deletions com.avaloq.tools.ddk.workflow/src/com/avaloq/tools/ddk/workflow/GenerateValid.mwe2
View file
Open in desktop

This file was deleted.